Skip to contentSkip to conversation

smp_call_function() friends and irq/bottom_half context

DISCUSSION 류호은 2 participants 3 messages May 10, 2018 – May 11, 2018

lore
Share & tools
lore

류호은

author
#0 lore raw

Hi, all.

I'm reading kernel/smp.c code and I found comments on smp_call_function() and smp_call_function_[single/many]
saying that these functions are cannot be called in interrupt disabled context or irq/bottom half handlers.

I understand that there is a potential deadlock issue when caller CPU of the functions is waiting for the completion of the callback of other CPUs. But I was wondering if this is the case even when the caller CPU doesn't wait for the completion (wait == 0).

Thank you.

#1 lore raw
Quoted 11 lines · ��ȣ��

Hi, all.

I'm reading kernel/smp.c code and I found comments on smp_call_function() and smp_call_function_[single/many]
saying that these functions are cannot be called in interrupt disabled context or irq/bottom half handlers.

I understand that there is a potential deadlock issue when caller CPU of the functions is waiting for the completion of the callback of other CPUs. But I was wondering if this is the case even when the caller CPU doesn't wait for the completion (wait == 0).

IIRC yes, because csd_lock(). You can however use smp_call_function_single_async() with your own csd. Be very careful though, it is very easy to construct deadlocks.

author
#2 lore raw
Quoted 19 lines

-----Original Message-----
From: Peter Zijlstra [mailto:[email protected]]
Sent: Thursday, May 10, 2018 7:17 PM
To: ��ȣ�� <[email protected]>
Cc: [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]
Subject: Re: smp_call_function() friends and irq/bottom_half context

Quoted 9 lines · ��ȣ��

Hi, all.

I'm reading kernel/smp.c code and I found comments on smp_call_function() and smp_call_function_[single/many]
saying that these functions are cannot be called in interrupt disabled context or irq/bottom half handlers.

I understand that there is a potential deadlock issue when caller CPU of the functions is waiting for the completion of the callback of other

Quoted 7 lines

CPUs.

Quoted 2 lines

But I was wondering if this is the case even when the caller CPU doesn't wait for the completion (wait == 0).

IIRC yes, because csd_lock(). You can however use smp_call_function_single_async() with your own csd. Be very careful though, it is very easy to construct deadlocks.

Thank you for the explanation and the suggestion.

Would you please explain more on csd lock and irq disabled or irq/bh context ? How can deadlocks happen when calling smp_call_function(wait=0) with irq disabled ? How can deadlocks happen when calling smp_call_function(wait=0) from irq or bottom half context ?

I think it as 2d array like call_single_data[caller cpu][target cpu].flags. csd_lock(csd[caller][target]) spins on the flag only when LOCKED is already set which means that the caller CPU already called smp_call_function(wait=0) and at the second calling of the function, the caller CPU spins on csd_lock(csd[caller][target]) but the target CPU is still processing its callback list (maybe processing other csd[other cpu][target]) and it does not yet process csd[caller][target]. But the callback list will be finally flushed and LOCKED flags is cleared of csd[caller][target] eventually ?