sched/fair: fix incorrect calculation of capacity in scale_rt_capacity
PATCH 1/1 sched/fair: fix incorrect calculation of capacity in scale_rt_capacity
div_u64 can only handle 32-bits divisor, if our divisor is with type of 64-bits, we should use div64_u64 instead, otherwise value of divisor will be cast to 32-bits, resulting in wrong calculation.
--- kernel/sched/fair.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
kernel/sched/fair.c +1 -1
@@ -6086,7 +6086,7 @@ static unsigned long scale_rt_capacity(int cpu) total =sched_avg_period () + delta; - used =div_u64 (avg, total); + used =div64_u64 (avg, total);if (likely (used <SCHED_CAPACITY_SCALE ))return SCHED_CAPACITY_SCALE - used;
Signature · 1 line
2.5.2
Peter Zijlstra
maintainerQuoted 14 lines · Chao Yu
div_u64can only handle 32-bits divisor, if our divisor is with type of 64-bits, we should usediv64_u64instead, otherwise value of divisor will be cast to 32-bits, resulting in wrong calculation.Signed-off-by Chao Yu <[email protected]>--- kernel/sched/fair.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)kernel/sched/fair.c +0
-0
kernel/sched/fair.c static unsigned long scale_rt_capacity(int cpu) · line 6089
Quoted 5 lines
kernel/sched/fair.c +1
-1@@ -6086,7 +6086,7 @@ static unsigned long scale_rt_capacity(int cpu) total =sched_avg_period () + delta; - used =div_u64 (avg, total); + used =div64_u64 (avg, total);
total here should not exceed 2*sched_avg_period() 'much', with the defaults this would end up being around 1e9.
So unless you prod at sysctl_sched_time_avg it should all work out fine with the 32bit divisor.
Have you seen problems here?