Skip to contentSkip to conversation

Asm style

DISCUSSION vda 2 participants 2 messages Nov 21, 2001

lore
Share & tools
lore

vda

author
#0 lore raw

I'm using GCC 3.0.1 and seeing "multi-line literals are deprecated". Since a patch is necessary for that (and someone submitted it already) I'd like to hear from big kernel guys what asm statement style to use:

	asm(
"		cmd	r,r\n"
"lbl:		cmd	r,r\n"
"		cmd	r,r\n"
		: spec
		: spec
	);
[variable width for labels? I don't like it] or
	asm(
	"	cmd	r,r\n"
	"lbl:	cmd	r,r\n"
	"	cmd	r,r\n"
		: spec
		: spec
	);
[better. But \n's are ugly] or
#define NL "\n"
	asm(
	"	cmd	r,r" NL
	"lbl:	cmd	r,r" NL
	"	cmd	r,r" NL
		: spec
		: spec
	);

[I like this: \n doesn't interfere with args]
or what?
--
vda

#1 lore raw
Quoted 19 lines · vda

I'm using GCC 3.0.1 and seeing "multi-line literals are deprecated". Since a patch is necessary for that (and someone submitted it already) I'd like to hear from big kernel guys what asm statement style to use:

	asm(
"		cmd	r,r\n"
"lbl:		cmd	r,r\n"
"		cmd	r,r\n"
		: spec
		: spec
	);
[variable width for labels? I don't like it] or
	asm(
	"	cmd	r,r\n"
	"lbl:	cmd	r,r\n"
	"	cmd	r,r\n"
		: spec
		: spec
	);

[better. But \n's are ugly] or

Quoted 8 lines
#define NL "\n"
	asm(
	"	cmd	r,r" NL
	"lbl:	cmd	r,r" NL
	"	cmd	r,r" NL
		: spec
		: spec
	);

There's also:

	asm("\
	cmd	r,r\n\
lbl:	cmd	r,r\n\
	cmd	r,r\n" : spec : spec);

Or something similar (the trailing "\" added for continuation). Probably the easiest way to patch existing asm.

Signature · 4 lines
 .----------=======-=-======-=========-----------=====------------=-=-----.
/                   Ben Collins    --    Debian GNU/Linux                  \
`  [email protected]  --  [email protected]  --  [email protected]  '
 `---=========------=======-------------=-=-----=-===-======-------=--=---'