Skip to contentSkip to conversation

Weird __put_user_asm behavior

DISCUSSION Frank Cornelis 1 participant 1 message Dec 26, 2001 1 message not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): 01122416414400.02578@manta

#1 lore raw

Hi,

Quoted 10 lines
Quoted 9 lines

So here it goes: when I patch the macro in include/asm-i386/uaccess.h named __put_user_asm using the patch below I cannot 'strace ls' anymore. The ld.so runtime linker just stops when preparing the program displaying a nice message; the same message as '/lib/ld-linux.so.2' generates when ran without any parameters.
The kernel messages of __put_user_asm go to: 0xbffffb44; then the program stops on the ld.so message.
But, 'strace'-ing of a static compiled program does the job as expected. What am I doing wrong?

Quoted 15 lines

include/asm-i386/uaccess.h line 201

Quoted 11 lines
include/asm-i386/uaccess.h +4 -0
@@ -194,6 +194,10 @@
  * aliasing issues.
  */
 #define __put_user_asm(x, addr, err, itype, rtype, ltype)	\
+do {								\
+	if (current->ptrace & PT_PTRACED) {			\
+		printk(KERN_DEBUG "__put_user_asm: %#x\n", (unsigned long)(addr)); \
+	}							\
 	__asm__ __volatile__(					\

This must be clobbering some registers and some users of __put_user_asm might not expect that... did you try saving/restoring all regs around this 'if'?

I tried to save/restore the eax register before/after the printk function call because this register is the only register on an i386 that a function may alter without preserving its previous contents (even when the function returns void).
What is weird is that an __asm__ __volatile__("nop") within the if-statement works so it's not the if-statement itself that is causing the problem, also works is a "push %eax\n\tpop %eax" so again it's not the stack that is causing the problem.
But, when I try to access the (addr) parameter then execve shows the ld.so message again. This is very odd because all it does is (in most cases because GCC optimizes a lot) pushing a general register containing (addr) onto the stack then call the function (I also tried a void func) and after the call restore esp.
So, any more advice on this?

Thanks in advance,
Frank.

PS: Yes, I'm a thesis student and I really need this :).