Skip to contentSkip to conversation

Pull request for pynfs

DISCUSSION Frank Filz 2 participants 3 messages Oct 16, 2015 – Oct 19, 2015

Subsystems (2)
lore
Share & tools
lore
#1 lore raw
Quoted 9 lines · Frank Filz

Bruce,

Please pull the top patch from:

https://github.com/ffilz/pynfs/commits/master

It fixes CID2 to allow NFS4_OK when SETCLIENTID with a different principal replaces a clientid that has no state, and adds CID2a which expects NFS4ERR_CLID_INUSE since it does have state.

Thanks!

This leave us with two test functions both named "testInUse".

I applied the following to get both tests working.

--b.

nfs4.0/servertests/st_setclientid.py +1 -1
index 0fb59cd7f542..fbeab22e5026 100644
@@ -50,7 +50,7 @@ def testClientUpdateCallback(t, env):
     res = c.close_file(t.code, fh, stateid)
     check(res, msg="Close after updating callback info")
     
-def testInUse(t, env):
+def testNotInUse(t, env):
     """SETCLIENTID with same nfs_client_id.id should return NFS4ERR_OK
        if there is no active state
 
author
#2 lore raw
Quoted 11 lines · Frank Filz
Quoted 9 lines

Bruce,

Please pull the top patch from:

https://github.com/ffilz/pynfs/commits/master

It fixes CID2 to allow NFS4_OK when SETCLIENTID with a different principal replaces a clientid that has no state, and adds CID2a which expects NFS4ERR_CLID_INUSE since it does have state.

Quoted 5 lines

Thanks!

This leave us with two test functions both named "testInUse".

I applied the following to get both tests working.

Oops, sorry...

Frank

Quoted 6 lines
nfs4.0/servertests/st_setclientid.py +0 -0
index 0fb59cd7f542..fbeab22e5026 100644

nfs4.0/servertests/st_setclientid.py def testClientUpdateCallback(t, env): · line 56

Quoted 8 lines
nfs4.0/servertests/st_setclientid.py +1 -1
@@ -50,7 +50,7 @@ def testClientUpdateCallback(t, env):
     res = c.close_file(t.code, fh, stateid)
     check(res, msg="Close after updating callback info")
 
-def testInUse(t, env):
+def testNotInUse(t, env):
     """SETCLIENTID with same nfs_client_id.id should return NFS4ERR_OK
        if there is no active state
 

---
This email has been checked for viruses by Avast antivirus software.
https://www.avast.com/antivirus