mce: acpi/apei: Only disable banks listed in HEST if mce is configured
Luck, Tony
reviewerPATCH 1/1 mce: acpi/apei: Only disable banks listed in HEST if mce is configured
From: "Naveen N. Rao" <[email protected]>
Randconfig testing found this error:
Quoted 1 line
Quoted 1 line
hest.c(.init.text+0x6004): undefined reference to 'mce_disable_bank'
Fix by wrapping body of hest_parse_cmc() inside #ifdef CONFIG_X86_MCE
---
[Peter: Thanks for pulling Naveen's series from my ras tree. Fengguang's
testbuild robot promtly found this build issue. Please apply this patch on top of the x86/mce branch. - Thanks]
drivers/acpi/apei/hest.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/acpi/apei/hest.c +2 -1
@@ -128,6 +128,7 @@ EXPORT_SYMBOL_GPL(apei_hest_parse);*/ static int __init hest_parse_cmc (struct acpi_hest_header *hest_hdr,void *data) { +#ifdef CONFIG_X86_MCE int i;struct acpi_hest_ia_corrected *cmc;struct acpi_hest_ia_error_bank *mc_bank;
@@ -152,7 +153,7 @@ static int __init hest_parse_cmc(struct acpi_hest_header *hest_hdr, void *data) mc_bank = (struct acpi_hest_ia_error_bank *)(cmc +1 );for (i =0 ; i < cmc->num_hardware_banks; i++, mc_bank++)mce_disable_bank (mc_bank->bank_number); - +#endif return 1 ; }
Signature · 1 line
1.8.1.4
Borislav Petkov
reviewerQuoted 11 lines · Tony
From: "Naveen N. Rao" <[email protected]>
Randconfig testing found this error:
Quoted 1 line
Quoted 1 line
hest.c(.init.text+0x6004): undefined reference to 'mce_disable_bank'Fix by wrapping body of
hest_parse_cmc()inside #ifdefCONFIG_X86_MCEReported-by "Wu, Fengguang" <[email protected]>Signed-off-by Naveen N. Rao <[email protected]>Signed-off-by Tony Luck <[email protected]>
Quoted 5 lines
---
[Peter: Thanks for pulling Naveen's series from my ras tree. Fengguang's
testbuild robot promtly found this build issue. Please apply this patch on top of the x86/mce branch. - Thanks]
This one still needs picking up since randconfig builds fail. hpa, can you apply to tip:x86/mce please?
Thanks.
Signature · 5 lines
Regards/Gruss,
Boris.
Sent from a fat crate under my desk. Formatting is fine.
--