fujitsu-laptop: use FB_BLANK_* constants
Subsystems (2)
A message that is not in the archive (sent off-list or not yet received): 0150118191421.GJ56582@vmdeb7
PATCH 1/1 fujitsu-laptop: use FB_BLANK_* constants
Replace the magic numbers in fujitsu-laptop.c by the appropriate FB_BLANK constants, as indicated by the comment for backlight_properties.power in include/linux/backlight.h.
Signed-off-by Michael Karcher <[email protected]>
--- drivers/platform/x86/fujitsu-laptop.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-)
drivers/platform/x86/fujitsu-laptop.c +4 -3
@@ -64,6 +64,7 @@#include <linux/acpi.h> #include <linux/dmi.h> #include <linux/backlight.h> +#include <linux/fb.h> #include <linux/input.h> #include <linux/kfifo.h> #include <linux/platform_device.h>
@@ -398,7 +399,7 @@ static int bl_get_brightness(struct backlight_device *b)static int bl_update_status (struct backlight_device *b) {int ret; -if (b->props.power ==4 ) +if (b->props.power ==FB_BLANK_POWERDOWN ) ret =call_fext_func (FUNC_BACKLIGHT ,0x1 ,0x4 ,0x3 );else ret =call_fext_func (FUNC_BACKLIGHT ,0x1 ,0x4 ,0x0 );
@@ -1139,9 +1140,9 @@ static int __init fujitsu_init(void)if (!acpi_video_backlight_support ()) {if (call_fext_func (FUNC_BACKLIGHT ,0x2 ,0x4 ,0x0 ) ==3 ) - fujitsu->bl_device->props.power =4 ; + fujitsu->bl_device->props.power =FB_BLANK_POWERDOWN ;else - fujitsu->bl_device->props.power =0 ; + fujitsu->bl_device->props.power =FB_BLANK_UNBLANK ; }pr_info ("driver " FUJITSU_DRIVER_VERSION " successfully loaded\n" );
Signature · 1 line
2.1.3
Quoted 5 lines · Michael Karcher
Replace the magic numbers in
fujitsu-laptop.cby the appropriateFB_BLANKconstants, as indicated by the comment for backlight_properties.power ininclude/linux/backlight.h.Signed-off-by Michael Karcher <[email protected]>
Thanks Michael, queued for 3.20.
Signature · 2 lines
Darren Hart Intel Open Source Technology Center
Quoted 8 lines · Darren Hart
Quoted 5 lines · Michael Karcher
Replace the magic numbers in
fujitsu-laptop.cby the appropriateFB_BLANKconstants, as indicated by the comment for backlight_properties.power ininclude/linux/backlight.h.Signed-off-by Michael Karcher <[email protected]>Thanks Michael, queued for 3.20.
Acked-by Jonathan Woithe <[email protected]>