net driver: Add support for SMSC LAN911x line of ethernet chips
A message that is not in the archive (sent off-list or not yet received): 021e01c66285$ca8b0a40$0a67020a@dustinlaptop
Quoted 8 lines · Dustin McIntire
This patch adds support for the SMSC LAN911x line of Ethernet chips. These
Ethernet controllers are a completely new register set from the old 91c9x and 91c911x parts. This driver has been tested using a PXA255 host processor, but has not been tested under other architectures. The driver was written in a hopefully generic enough way to extend support beyond just the ARM. I'm hoping for comments regarding its suitability for inclusion into the kernel tree.
The patch was badly wordwrapped. Please fix and resend.
I'd suggest that you enable it on all architectures, not just CONFIG_ARM. Tht way we'll at least get compile coverage.
Coding style problems:
- The code uses four-spaces where it should be using hard tabs. Linux style is to always use hard tabs.
- The code does this:
if( while(
Linux style is
if ( while (
- Try to keep everything inside the 80th column. (This is especially useful when sending wordwrapped patches ;))
Quoted 3 lines
The patch was badly wordwrapped. Please fix and resend.
OK, I've fixed the wrapping and removed the CONFIG_ARM restriction. I've also did my best to modify the C style to conform to the comments.
I noticed that the patch is getting ignored by majordomo due to its size >100K. Should it be broken up somehow to allow posting to the lists?
drivers/net/Kconfig +16 -0
@@ -865,6 +865,22 @@ config DM9000 <file:Documentation/networking/net-modules.txt>. The module will be called dm9000. +config SMC911X + tristate "SMSC LAN911[5678] support" + select CRC32 + select MII + depends on NET_ETHERNET + help + This is a driver for SMSC's LAN911x series of Ethernet chipsets + including the new LAN9115, LAN9116, LAN9117, and LAN9118. + Say Y if you want it compiled into the kernel, + and read the Ethernet-HOWTO, available from + <http://www.linuxdoc.org/docs.html#howto>. + + This driver is also available as a module. The module will be + called smc911x. If you want to compile it as a module, say M + here and read <file:Documentation/modules.txt> + config NET_VENDOR_RACAL bool "Racal-Interlan (Micom) NI cards" depends on NET_ETHERNET && ISA
drivers/net/Makefile +1 -0
@@ -193,6 +193,7 @@ obj-$(CONFIG_AMD8111_ETH) += amd8111e.o obj-$(CONFIG_IBMVETH) += ibmveth.o obj-$(CONFIG_S2IO) += s2io.o obj-$(CONFIG_SMC91X) += smc91x.o +obj-$(CONFIG_SMC911X) += smc911x.o obj-$(CONFIG_DM9000) += dm9000.o obj-$(CONFIG_FEC_8XX) += fec_8xx/
drivers/net/smc911x.c +2307 -0
2,307 lines not on this page · raw message
drivers/net/smc911x.h +835 -0
664 lines not on this page · raw message
The rest of this diff is not shown. View the raw message.
Part of the diff is not shown here. View the raw message.