move file->f_op->open out of mutex (misc_mtx) in misc_open
Quoted 19 lines
misc_mtxwas used to mutexmisc_list.
Butfile->f_op->openmay be blocked by downloading firmware in some devices' open.
So movefile->f_op->openout of mutex (misc_mtx) inmisc_opento avoid this block.
It also make code more efficiency.Signed-off-by Zhang Dongxing <[email protected]>Signed-off-by xiaoming wang <[email protected]>--- drivers/char/misc.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)drivers/char/misc.c +0
-0
drivers/char/misc.c static int misc_open(struct inode * inode, struct file * file) · line 149
Quoted 7 lines
drivers/char/misc.c +2
-1@@ -144,7 +144,8 @@ static int misc_open(struct inode * inode, struct file * file)replace_fops (file, new_fops);if (file->f_op->open) { file->private_data = c; - err = file->f_op->open (inode,file); +mutex_unlock (&misc_mtx); +return file->f_op->open (inode,file); }
What if unregister breaks in while opening?
Quoted 4 lines
drivers/char/misc.c +0
-1fail:mutex_unlock (&misc_mtx); --1.7.9.5