tests/kms_vrr: Reset to High refresh rate before begin drrs test
A message that is not in the archive (sent off-list or not yet received): [email protected]
PATCH 1/1 tests/kms_vrr: Reset to High refresh rate before begin drrs test
Sink with DRRS and VRR can be in downclock mode,
so switch to High clock mode as test preparation.
--- tests/kms_vrr.c | 8 ++++++++ 1 file changed, 8 insertions(+)
tests/kms_vrr.c +8 -0
@@ -522,6 +522,14 @@ test_seamless_rr_basic(data_t *data, enum pipe pipe, igt_output_t *output, uint3if (vrr)set_vrr_on_pipe (data, pipe, false, true); +else { +/* +Sink with DRRS and VRR can be in downclock mode. +so switch to High clock mode as test preparation +*/ +igt_output_override_mode (output, &data->switch_modes[HIGH_RR_MODE ]); +igt_assert (igt_display_try_commit_atomic (&data->display,DRM_MODE_PAGE_FLIP_EVENT ,NULL ) ==0 ); + } rate = vtest_ns.max; result =flip_and_measure (data, output, pipe, rate,TEST_DURATION_NS );
Signature · 1 line
2.33.0
Hi Vidya,
Quoted 13 lines · Vidya Srinivas
Sink with DRRS and VRR can be in downclock mode,
so switch to High clock mode as test preparation.Signed-off-by Vidya Srinivas <[email protected]>--- tests/kms_vrr.c | 8 ++++++++ 1 file changed, 8 insertions(+)tests/kms_vrr.c +0
-0
tests/kms_vrr.c test_seamless_rr_basic(data_t *data, enum pipe pipe, igt_output_t *output, uint3 · line 528
Quoted 7 lines
tests/kms_vrr.c +4
-0@@ -522,6 +522,14 @@ test_seamless_rr_basic(data_t *data, enum pipe pipe, igt_output_t *output, uint3if (vrr)set_vrr_on_pipe (data, pipe, false, true); +else { +/* +Sink with DRRS and VRR can be in downclock mode. +so switch to High clock mode as test preparation
Please use proper commenting style:
Example:
/* This is single line comment. */
/*
* This is multiline
* comment.
*/
No need to float the new rev, please fix this while merging the patch.
- Bhanu
Quoted 7 lines
tests/kms_vrr.c +4
-0+*/ +igt_output_override_mode (output, &data->switch_modes[HIGH_RR_MODE ]); +igt_assert (igt_display_try_commit_atomic (&data->display,DRM_MODE_PAGE_FLIP_EVENT ,NULL ) ==0 ); + } rate = vtest_ns.max; result =flip_and_measure (data, output, pipe, rate,TEST_DURATION_NS );
Quoted 39 lines
-----Original Message-----
From: Modem, Bhanuprakash <[email protected]>
Sent: Thursday, January 25, 2024 3:27 PM
To: Srinivas, Vidya <[email protected]>; [email protected]
Subject: Re: [PATCH i-g-t] tests/kms_vrr: Reset to High refresh rate before begin drrs testHi Vidya,
Quoted 17 lines · Vidya Srinivas
Sink with DRRS and VRR can be in downclock mode, so switch to High clock mode as test preparation.
Signed-off-by Vidya Srinivas <[email protected]>--- tests/kms_vrr.c | 8 ++++++++ 1 file changed, 8 insertions(+)tests/kms_vrr.c index renamed from tests/kms_vrr.c +0
-0
44bc3480d..697697b4e100644tests/kms_vrr.c +0
-0@@ -522,6 +522,14 @@ test_seamless_rr_basic(data_t *data, enum pipepipe,
igt_output_t*output, uint3if (vrr) set_vrr_on_pipe(data, pipe, false, true);tests/kms_vrr.c test_seamless_rr_basic(data_t *data, enum pipe pipe, igt_output_t *output, uint3 · line 528
Quoted 4 lines
tests/kms_vrr.c +4
-0+else { +/* +Sink with DRRS and VRR can be in downclock mode. +so switch to High clock mode as test preparation Please use proper commenting style:
Example:
/* This is single line comment. */
Quoted 7 lines
/*
* This is multiline
* comment.
*/No need to float the new rev, please fix this while merging the patch.
Hello Bhanu, apologies for not noticing that. Thank you.
Regards
Vidya
Quoted 14 lines
Reviewed-by Bhanuprakash Modem <[email protected]>- Bhanu
tests/kms_vrr.c
Quoted 4 lines
tests/kms_vrr.c +2
-0+*/ + igt_output_override_mode(output, &data-switch_modes[HIGH_RR_MODE]);
tests/kms_vrr.c +1
-0+ igt_assert(igt_display_try_commit_atomic(&data->display,
DRM_MODE_PAGE_FLIP_EVENT, NULL) == 0);Quoted 5 lines
tests/kms_vrr.c +1
-0+ } rate = vtest_ns.max; result = flip_and_measure(data, output, pipe, rate,
TEST_DURATION_NS);