Skip to contentSkip to conversation

fs: New zonefs file system

PATCH Markus Elfring 1 participant 1 message Feb 6, 2020 VFS

lore
Share & tools
lore
#0 lore raw
Quoted 1 line

zonefs is a very simple file system …

How do you think about to be consistent with the capitalisation at the beginning of such sentences?
https://lore.kernel.org/linux-fsdevel/[email protected]/

…

Quoted 1 line

+++ b/fs/zonefs/super.c

…

Quoted 3 lines
(quoted diff) +3 -0
+static int zonefs_create_zgroup(struct zonefs_zone_data *zd,
+				enum zonefs_ztype type)
+{

…

Review

Quoted 4 lines
(quoted diff) +4 -0
+	if (type == ZONEFS_ZTYPE_CNV)
+		zgroup_name = "cnv";
+	else
+		zgroup_name = "seq";

I find the following code variant more succinct.

+ zgroup_name = (type == ZONEFS_ZTYPE_CNV) ? "cnv" : "seq";

Regards,
Markus