Skip to contentSkip to conversation

High Speed uart support on 3430

RFC PATCH In review Girish 3 participants 4 messages Dec 17, 2007 – Dec 19, 2007

lore
Share & tools
lore

Girish

author
#0 lore raw

cover High Speed uart support on 3430

Hi,
This patch series adds high speed uart support on 3430.

UART library Interfaces:
The UART library interfaces the user drivers with UART hardware and exports API’s to configure UART for different types of applications such as High speed(HS) UART, IrDA and Bluetooth etc.
The most of the API’s exported by UART library are functionality based API’s which are used by client drivers for different purposes such as
- Requesting UART
- Initial UART configuration
- Data transfer Configuration(DMA mode)
- ISR registration
- UART Speed change

Regards,
Girish

#1 lore raw

Review

Quoted 13 lines · Girish

Hi,
This patch series adds high speed uart support on 3430.

UART library Interfaces:
The UART library interfaces the user drivers with UART hardware and exports API’s to configure UART for different types of applications such as High speed(HS) UART, IrDA and Bluetooth etc.
The most of the API’s exported by UART library are functionality based API’s which are used by client drivers for different purposes such as

(quoted diff) +0 -5
-	Requesting UART
-	Initial UART configuration
-	Data transfer Configuration(DMA mode)
-	ISR registration
-	UART Speed change

Well all that sounds good, but please move the driver to drivers/serial to start with.

Regards,

Tony

author
#2 lore raw
Quoted 6 lines

-----Original Message-----
From: Tony Lindgren [mailto:[email protected]]
Sent: Monday, December 17, 2007 11:07 PM

Quoted 6 lines

Review

Quoted 3 lines
(quoted diff) +0 -3
-	Data transfer Configuration(DMA mode)
-	ISR registration
-	UART Speed change

Well all that sounds good, but please move the driver to drivers/serial to start with.

This UART driver is more like an independent library which doesn't interface with serial framework so this might not fit in driver/serial. Any comments?

Regards,
Girish

#3 lore raw
Quoted 5 lines · ext Girish
Quoted 4 lines

-----Original Message-----
From: Tony Lindgren [mailto:[email protected]] Sent: Monday, December 17, 2007 11:07 PM

Quoted 7 lines
Quoted 4 lines

Review

Quoted 3 lines
(quoted diff) +0 -3
-	Data transfer Configuration(DMA mode)
-	ISR registration
-	UART Speed change

Well all that sounds good, but please move the driver to drivers/serial to start with.

This UART driver is more like an independent library which doesn't interface with serial framework so this might not fit in driver/serial. Any comments?

Is it possible to make a driver for omap uarts based on your library? Current generic drivers seems to trigger some hw(?) bugs, so at least in
we had to use custom serial driver. Also working power management was
added so that clock are not used when the uart is not actually used.

Signature · 1 line
Ville