media: rc: ati_remote.c: code style and compile warning fixing
Quoted 1 line
Review
Quoted 1 line
(quoted diff) +0
-0
b/drivers/media/rc/ati_remote.c
Quoted 4 lines
Quoted 4 lines
index 7be377f..0df66ac 100644
drivers/media/rc/ati_remote.c +0
-0@@ -23,6 +23,8 @@
Quoted 8 lines
drivers/media/rc/ati_remote.c line 27
Quoted 5 lines
drivers/media/rc/ati_remote.c +2
-0* Vincent Vanackere <[email protected]> * Added support for the "Lola" remote contributed by: * Seth Cohn <[email protected]> +* Jul 2012: Du, Changbin <[email protected]> +* Code style and compile warning fixing You shouldn't be changing the driver's authorship just due to codingstyle and warning fixes. Btw, Please split Coding Style form Compilation
warnings,
Quoted 1 line
as they're two different matters.
Sorry, I didn't know this rule. I just want to make a track for me. OK, I will resend this patch and remove me from it.
BTW, I am looking for something to learn these basic rules when sending patches. Could you tell me where I can find it?
Many thanks!
[Du, Changbin]
Quoted 3 lines
Thanks!
Mauro
Em 06-07-2012 22:49, Du Changbin escreveu:
Quoted 14 lines
Quoted 1 line
Review
Quoted 1 line
(quoted diff) +0
-0
b/drivers/media/rc/ati_remote.cQuoted 4 lines
Quoted 4 lines
index 7be377f..0df66ac 100644
drivers/media/rc/ati_remote.c +0
-0@@ -23,6 +23,8 @@Quoted 8 lines
drivers/media/rc/ati_remote.c line 27
Quoted 5 lines
drivers/media/rc/ati_remote.c +2
-0* Vincent Vanackere <[email protected]> * Added support for the "Lola" remote contributed by: * Seth Cohn <[email protected]> +* Jul 2012: Du, Changbin <[email protected]> +* Code style and compile warning fixing You shouldn't be changing the driver's authorship just due to codingstyle and warning fixes. Btw, Please split Coding Style form Compilation
Quoted 7 lines
warnings,
Quoted 1 line
as they're two different matters.
Sorry, I didn't know this rule. I just want to make a track for me. OK, I will resend this patch and remove me from it.
BTW, I am looking for something to learn these basic rules when sending patches. Could you tell me where I can find it?
There are some rules at linuxtv wiki pages, others at the Kernel Documentation dir and other not so explicit rules like the above that you'll get as you continue contributing ;)
In opposite to other open source projects, the contribution history is the git logs, and not inside the comments at the source code.
Quoted 2 lines
Many thanks!
[Du, Changbin]
Thanks,
Mauro