usb: serial: ftdi_sio Added 0a5c:6422 device ID for WICED USB UART dev board

PATCH In review Sheng-Hui J. Chu 3 participants 4 messages Jul 28, 2016 – Aug 8, 2016

Subsystems (2)

USB USB serial

lore

Share & tools

lore

Sheng-Hui J. Chu

author

2016-07-28 21:01 UTC #0 lore raw

PATCH v6 1/1 usb: serial: ftdi_sio Added 0a5c:6422 device ID for WICED USB UART dev board

BCM20706V2_EVAL is a WICED dev board designed with FT2232H USB 2.0 UART/FIFO IC.

To support BCM920706V2_EVAL dev board for WICED development on Linux. Add the VID(0a5c) and PID(6422) to ftdi_sio driver to allow loading ftdi_sio for this board.

Signed-off-by Sheng-Hui J. Chu <[email protected]>

---
 drivers/usb/serial/ftdi_sio.c	   | 1 +
 drivers/usb/serial/ftdi_sio_ids.h | 6 ++++++++
 2 files changed, 7 insertions(+)

drivers/usb/serial/ftdi_sio.c +0 -0

index 0082080..ef19af4 100644
@@ -1008,6 +1008,7 @@ static const struct usb_device_id id_table_combined[] = {

	{ USB_DEVICE(ICPDAS_VID, ICPDAS_I7560U_PID) },
	{ USB_DEVICE(ICPDAS_VID, ICPDAS_I7561U_PID) },
	{ USB_DEVICE(ICPDAS_VID, ICPDAS_I7563U_PID) },
+	{ USB_DEVICE(WICED_USB_VID, WICED_USB20706V2_PID) },
	{ }					/* Terminating entry */

};

drivers/usb/serial/ftdi_sio_ids.h +6 -0

index c5d6c1e..b29f280 100644
@@ -1485,3 +1485,11 @@
 #define CHETCO_SEASMART_DISPLAY_PID	0xA5AD /* SeaSmart NMEA2000 Display */
 #define CHETCO_SEASMART_LITE_PID	0xA5AE /* SeaSmart Lite USB Adapter */
 #define CHETCO_SEASMART_ANALOG_PID	0xA5AF /* SeaSmart Analog Adapter */
+
+/*
+ * WICED USB UART
+ */
+#define WICED_USB_VID		0x0A5C
+#define WICED_USB20706V2_PID	0x6422

Signature · 1 line

2.1.4

Greg KH

maintainer

2016-07-28 21:08 UTC #1 lore raw

Quoted 39 lines · Sheng-Hui J. Chu

BCM20706V2_EVAL is a WICED dev board designed with FT2232H USB 2.0 UART/FIFO IC.

To support BCM920706V2_EVAL dev board for WICED development on Linux. Add the VID(0a5c) and PID(6422) to ftdi_sio driver to allow loading ftdi_sio for this board.

Signed-off-by Sheng-Hui J. Chu <[email protected]>

---
 drivers/usb/serial/ftdi_sio.c	   | 1 +
 drivers/usb/serial/ftdi_sio_ids.h | 6 ++++++++
 2 files changed, 7 insertions(+)

drivers/usb/serial/ftdi_sio.c +1 -0

index 0082080..ef19af4 100644
@@ -1008,6 +1008,7 @@ static const struct usb_device_id id_table_combined[] = {
 	{ USB_DEVICE(ICPDAS_VID, ICPDAS_I7560U_PID) },
 	{ USB_DEVICE(ICPDAS_VID, ICPDAS_I7561U_PID) },
 	{ USB_DEVICE(ICPDAS_VID, ICPDAS_I7563U_PID) },
+	{ USB_DEVICE(WICED_USB_VID, WICED_USB20706V2_PID) },
 	{ }					/* Terminating entry */
 };

drivers/usb/serial/ftdi_sio_ids.h +6 -0

index c5d6c1e..b29f280 100644
@@ -1485,3 +1485,11 @@
 #define CHETCO_SEASMART_DISPLAY_PID	0xA5AD /* SeaSmart NMEA2000 Display */
 #define CHETCO_SEASMART_LITE_PID	0xA5AE /* SeaSmart Lite USB Adapter */
 #define CHETCO_SEASMART_ANALOG_PID	0xA5AF /* SeaSmart Analog Adapter */
+
+/*
+ * WICED USB UART
+ */
+#define WICED_USB_VID		0x0A5C
+#define WICED_USB20706V2_PID	0x6422

Signature · 1 line

2.1.4

Yeah!!!

I'll let Johan queue this up, and forward it on to my trees in a few days. Thanks so much for sticking with this.

greg k-h

From: Greg KH [mailto:[email protected]]
Sent: Thursday, July 28, 2016 5:09 PM
To: Sheng-Hui J. Chu <[email protected]>
Cc: [email protected]; [email protected]; [email protected]
Subject: Re: [PATCH v6] usb: serial: ftdi_sio Added 0a5c:6422 device ID for WICED USB UART dev board

Quoted 39 lines · Sheng-Hui J. Chu

BCM20706V2_EVAL is a WICED dev board designed with FT2232H USB 2.0 UART/FIFO IC.

To support BCM920706V2_EVAL dev board for WICED development on Linux. Add the VID(0a5c) and PID(6422) to ftdi_sio driver to allow loading ftdi_sio for this board.

Signed-off-by Sheng-Hui J. Chu <[email protected]>

---
 drivers/usb/serial/ftdi_sio.c	   | 1 +
 drivers/usb/serial/ftdi_sio_ids.h | 6 ++++++++
 2 files changed, 7 insertions(+)

drivers/usb/serial/ftdi_sio.c +1 -0

index 0082080..ef19af4 100644
@@ -1008,6 +1008,7 @@ static const struct usb_device_id id_table_combined[] = {
 	{ USB_DEVICE(ICPDAS_VID, ICPDAS_I7560U_PID) },
 	{ USB_DEVICE(ICPDAS_VID, ICPDAS_I7561U_PID) },
 	{ USB_DEVICE(ICPDAS_VID, ICPDAS_I7563U_PID) },
+	{ USB_DEVICE(WICED_USB_VID, WICED_USB20706V2_PID) },
 	{ }					/* Terminating entry */
 };

drivers/usb/serial/ftdi_sio_ids.h +6 -0

index c5d6c1e..b29f280 100644
@@ -1485,3 +1485,11 @@
 #define CHETCO_SEASMART_DISPLAY_PID	0xA5AD /* SeaSmart NMEA2000 Display */
 #define CHETCO_SEASMART_LITE_PID	0xA5AE /* SeaSmart Lite USB Adapter */
 #define CHETCO_SEASMART_ANALOG_PID	0xA5AF /* SeaSmart Analog Adapter */
+
+/*
+ * WICED USB UART
+ */
+#define WICED_USB_VID		0x0A5C
+#define WICED_USB20706V2_PID	0x6422

Signature · 1 line

2.1.4

Yeah!!!

I'll let Johan queue this up, and forward it on to my trees in a few days. Thanks so much for sticking with this.

greg k-h

Thank you very much for your patience and guidance.

-Jeffrey

Johan Hovold

maintainer

2016-08-08 10:28 UTC #3 lore raw

In reply to Sheng-Hui J. Chu

Quoted 28 lines · Sheng-Hui J. Chu

BCM20706V2_EVAL is a WICED dev board designed with FT2232H USB 2.0 UART/FIFO IC.
To support BCM920706V2_EVAL dev board for WICED development on Linux. Add the VID(0a5c) and PID(6422) to ftdi_sio driver to allow loading ftdi_sio for this board.
Signed-off-by Sheng-Hui J. Chu <[email protected]>
---
 drivers/usb/serial/ftdi_sio.c	   | 1 +
 drivers/usb/serial/ftdi_sio_ids.h | 6 ++++++++
 2 files changed, 7 insertions(+)
drivers/usb/serial/ftdi_sio.c +1 -0
index 0082080..ef19af4 100644
@@ -1008,6 +1008,7 @@ static const struct usb_device_id id_table_combined[] = {
 	{ USB_DEVICE(ICPDAS_VID, ICPDAS_I7560U_PID) },
 	{ USB_DEVICE(ICPDAS_VID, ICPDAS_I7561U_PID) },
 	{ USB_DEVICE(ICPDAS_VID, ICPDAS_I7563U_PID) },
+	{ USB_DEVICE(WICED_USB_VID, WICED_USB20706V2_PID) },
 	{ }					/* Terminating entry */
 };
 
drivers/usb/serial/ftdi_sio_ids.h +0 -0
index c5d6c1e..b29f280 100644

drivers/usb/serial/ftdi_sio_ids.h line 1493

Quoted 9 lines

drivers/usb/serial/ftdi_sio_ids.h +6 -0

@@ -1485,3 +1485,11 @@
 #define CHETCO_SEASMART_DISPLAY_PID	0xA5AD /* SeaSmart NMEA2000 Display */
 #define CHETCO_SEASMART_LITE_PID	0xA5AE /* SeaSmart Lite USB Adapter */
 #define CHETCO_SEASMART_ANALOG_PID	0xA5AF /* SeaSmart Analog Adapter */
+
+/*
+ * WICED USB UART
+ */
+#define WICED_USB_VID		0x0A5C
+#define WICED_USB20706V2_PID	0x6422

This patch still failed to apply:

Applying: usb: serial: ftdi_sio Added 0a5c:6422 device ID for WICED USB UART dev board
fatal: corrupt patch at line 11
Patch failed at 0001 usb: serial: ftdi_sio Added 0a5c:6422 device ID for WICED USB UART dev board

and checkpatch also complained about possible line wrapping.

I fixed it up here before applying, but next time please try sending the patch to yourself and make sure it still applies before posting to the list.

Thanks,
Johan