missing expat-dirclean target

expat.mk line 70

Quoted 6 lines · Cristian Ionescu-Idbohrn

Index: expat.mk
===================================================================

expat.mk +0 -0

@@ -70,6 +70,9 @@
 	#rm -f $(STAGING_DIR)/usr/bin/xmlwf  $(TARGET_DIR)/usr/bin/xmlwf

the clean target must wipe installed stuff from the staging-dir. Please fix this, too.

this package uses wrong installation pathes, please fix and test while you're at it (i don't use it):

                --includedir=/include \

is wrong, whould be /usr/include. Most of these pathes are not needed, just --prefix=/usr should be enough.

Quoted 10 lines · Bernhard Fischer

expat.mk line 70

Quoted 6 lines · Cristian Ionescu-Idbohrn

Index: expat.mk
===================================================================

expat.mk +0 -0

@@ -70,6 +70,9 @@
 	#rm -f $(STAGING_DIR)/usr/bin/xmlwf  $(TARGET_DIR)/usr/bin/xmlwf

the clean target must wipe installed stuff from the staging-dir. Please fix this, too.

Looks like stuff is removed both from STAGING_DIR and TARGET_DIR. Is this the correct behaviour?

Quoted 6 lines

this package uses wrong installation pathes, please fix and test while you're at it (i don't use it):

                --includedir=/include \

is wrong, whould be /usr/include. Most of these pathes are not needed, just --prefix=/usr should be enough.

Will do.

Quoted 3 lines · Cristian Ionescu-Idbohrn

Looks like stuff is removed both from STAGING_DIR and TARGET_DIR. Is this the correct behaviour?

I think removing stuff from both staging_dir and target_dir is the way to go, yes.

Consider somebody intending to turn off a package. The usual intuitive way is IMHO to make foo-clean then reconfigure to remove that package.

I'm open to alternative suggestions, of course.

Quoted 7 lines · Bernhard Fischer

Quoted 3 lines · Cristian Ionescu-Idbohrn

Looks like stuff is removed both from STAGING_DIR and TARGET_DIR. Is this the correct behaviour?

I think removing stuff from both staging_dir and target_dir is the way to go, yes.

Alright. I still wish every makefile had a target called called <something>-uninstall to do that.

Quoted 3 lines

Consider somebody intending to turn off a package. The usual intuitive way is IMHO to make foo-clean then reconfigure to remove that package.

Quoted 1 line

I'm open to alternative suggestions, of course.

This is how I wish it was done (looks more intuitive to me):

<something>-clean does the usual 'make clean' stuff
<something>-dirclean wipes out the build directory
<something>-uninstall wipes whatever was installed

Quoted 8 lines

Quoted 6 lines

this package uses wrong installation pathes, please fix and test while you're at it (i don't use it):

                --includedir=/include \

is wrong, whould be /usr/include. Most of these pathes are not needed, just --prefix=/usr should be enough.

Will do.

thanks alot in advance!