Skip to contentSkip to conversation

net: sxgbe: add basic framework for Samsung 10Gb ethernet driver

DISCUSSION Kukjin Kim 2 participants 2 messages Jan 6, 2015 Kernel janitors

lore
Share & tools
lore

Kukjin Kim

author
#0 lore raw

Hi Dan,

This is Kukjin and Byungho asked to re-send following to you because of e-mail client problem on his desktop, anyway see below :)

Thanks,
Kukjin

(+ Byungho's personal e-mail account)

Quoted 2 lines · Dan Carpenter

Whatever happened with this? Who is maintaining this now that Silva isn't around?

Hi Dan and all,

Happy New Year :-)

Yeah, Siva resigned with personal reason and as you know, unfortunately his name is already removed from maintainer list.

Quoted 6 lines · Dan Carpenter
Quoted 5 lines

Silva's email bounces.

Quoted 2 lines · Dan Carpenter

Hello Siva Reddy,

Quoted 7 lines
Quoted 7 lines
Quoted 7 lines

The patch 1edb9ca69e8a: "net: sxgbe: add basic framework for Samsung 10Gb ethernet driver" from Mar 25, 2014, leads to the following static checker warning:

drivers/net/ethernet/samsung/sxgbe/sxgbe_main.c:505 init_rx_ring()
warning: passing freed memory 'rx_ring->rx_skbuff'

Yeah, the checker is right and it should be fixed. I'm sorry to be in my carelessness. To be honest I've missed the warning messages...

Quoted 10 lines
Quoted 10 lines
Quoted 10 lines

drivers/net/ethernet/samsung/sxgbe/sxgbe_main.c

   500          return 0;
   501  
   502  err_init_rx_buffers:
   503          while (--desc_index >= 0)
   504                  free_rx_ring(priv->device, rx_ring, desc_index);
                                                   "^^

We free "rx_ring->rx_skbuff" and "rx_ring->rx_skbuff_dma" here so the next two kfree() calls are double frees.

Yes, correct.

Quoted 10 lines
Quoted 10 lines
Quoted 10 lines
   505          kfree(rx_ring->rx_skbuff);
   506  rxbuff_err:
   507          kfree(rx_ring->rx_skbuff_dma);
   508  dmamem_err:
   509          dma_free_coherent(priv->device,
   510                            rx_rsize * sizeof(struct sxgbe_rx_norm_desc),
   511                            rx_ring->dma_rx, rx_ring->dma_rx_phy);
   512  error:
   513          return -ENOMEM;
   514  }

Thanks for your gentle notification and let me fix it soon ;)

Byungho An

#1 lore raw
Quoted 7 lines
Quoted 7 lines
Quoted 7 lines · Dan Carpenter
Quoted 6 lines

Hello Siva Reddy,

The patch 1edb9ca69e8a: "net: sxgbe: add basic framework for Samsung 10Gb ethernet driver" from Mar 25, 2014, leads to the following static checker warning:

Quoted 6 lines
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines

drivers/net/ethernet/samsung/sxgbe/sxgbe_main.c:505 init_rx_ring()
warning: passing freed memory 'rx_ring->rx_skbuff'

Yeah, the checker is right and it should be fixed. I'm sorry to be in my carelessness. To be honest I've missed the warning messages...

No no. No problems. This is a Smatch warning and you need the cross function database configured. I wasn't expecting that you would see the warnings.

regards,
dan carpenter