Skip to contentSkip to conversation

iommu/qcom: Fix local_base status check

PATCH Markus Elfring 1 participant 1 message Apr 3, 2020

Subsystems (2)
lore
Share & tools
lore
#0 lore raw
Quoted 1 line

Release resources when exiting on error.

I have got doubts that such a change description fits to the proposed source code adjustment.

…

Review static int qcom_iommu_device_probe(struct platform_device *pdev) · line 822

Quoted 13 lines

+++ b/drivers/iommu/qcom_iommu.c

(quoted diff) +4 -1
@@ -813,8 +813,11 @@ static int qcom_iommu_device_probe(struct platform_device *pdev)
 	qcom_iommu->dev = dev;
 
 	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
-	if (res)
+	if (res) {
 		qcom_iommu->local_base = devm_ioremap_resource(dev, res);
+		if (IS_ERR(qcom_iommu->local_base))
+			return PTR_ERR(qcom_iommu->local_base);
+	}
 
 	qcom_iommu->iface_clk = devm_clk_get(dev, "iface");

…

Will the commit message be improved any further?

Would you like to add the tag “Fixes”?

Regards,
Markus