ACPI / bus: Remove checks in acpi_get_match_data()

Quoted 15 lines · Rafael J. Wysocki

Quoted 13 lines · Sinan Kaya

Quoted 11 lines · Andy Shevchenko

As well as its sibling of_device_get_match_data() has no such checks,
no need to do it in acpi_get_match_data().

First of all, we are not supposed to call fwnode API like this without
driver attached.

Second, if pure OF driver calls this function, it's weird to have ACPI
companion without ACPI ID in this case.

Quoted 7 lines

Quoted 5 lines

We talked about this during review.

of_match_device() does all the checking for the OF part. ACPI doesn't have
any checks.

Yeah, this patch is just plain incorrect AFAICS.

I don't see how check dev->driver is implemented on OF side then

of_device_get_match_data() which is called by of_fwnode_device_get_match_data() has dereferenced dev->driver w/o any check.

I can't agree that the patch is plain incorrect, if I didn't miss anything.