Skip to contentSkip to conversation

syscalls/io_submit: Add TTERRNO/TERRNO when test fail

PATCH zhaogongyi via ltp 1 participant 1 message Apr 21, 2022

lore
Share & tools
lore
#0 lore raw

Hi Cyril,

Thans for your review!

I have resubmit a patch, please see: https://patchwork.ozlabs.org/project/ltp/patch/[email protected]/

Best wishes!

Gongyi

Quoted 54 lines

Hi!

Quoted 5 lines
Quoted 5 lines

NACK.

As far as I can tell the io_submit() calls returns negative error instead of setting errno, at least that's what libaio documentation

states.

Quoted 2 lines

Yes, according to linux manual, libaio interface don't set errno when

calling failed, so, do we also need to remove the TREENO here?

Quoted 4 lines

80 TEST(io_setup(1, &ctx));
81 if (TST_RET == -ENOSYS)
82 tst_brk(TCONF | TRERRNO, "io_setup(): AIO not

supported by kernel");

Quoted 2 lines

83 else if (TST_RET)
84 tst_brk(TBROK | TRERRNO, "io_setup() failed");

Yes please, this should be replaced by manually printing tst_strerrno(-TST_RET).

Quoted 10 lines
Quoted 10 lines

testcases/kernel/syscalls/io_submit/io_submit02.c static void run(unsigned int i) · line 82

Quoted 10 lines
testcases/kernel/syscalls/io_submit/io_submit02.c +0 -1
index 38b8555d8..6ba4d99a5 100644
@@ -79,7 +79,7 @@ static void run(unsigned int i)
 	if (TST_RET == tc[i].nr)
 		tst_res(TPASS, "io_submit() %s", tc[i].desc);
 	else
-		tst_res(TFAIL, "io_submit() returns %ld, expected %ld",

TST_RET,

Quoted 9 lines
Quoted 7 lines

tc[i].nr);

testcases/kernel/syscalls/io_submit/io_submit02.c static void run(unsigned int i) · line 82

Quoted 1 line
testcases/kernel/syscalls/io_submit/io_submit02.c +1 -0
+		tst_res(TFAIL | TTERRNO, "io_submit() returns %ld,

expected %ld",

testcases/kernel/syscalls/io_submit/io_submit02.c static void run(unsigned int i) · line 83

Quoted 1 line
testcases/kernel/syscalls/io_submit/io_submit02.c +1 -0
+TST_RET, tc[i].nr);

The best we can do here is to use tst_strerrno() to print the error as we do in the io_submit().

According to linux manual, call io_submit through syscall, it will set

errno:

Quoted 1 line

"If the system call is invoked via syscall(2), then the return value

follows the usual conventions for indicating an error: -1, with errno set to a

Quoted 1 line

(positive) value that indicates the error."

Ah right, as long as we use the syscall() wrapper the negative error return value will be moved to the errno variable by the wrapper, so this part is correct.

--
Cyril Hrubis
[email protected]

Signature · 1 line
Mailing list info: https://lists.linux.it/listinfo/ltp