Skip to contentSkip to conversation

CONFIG_OF_EMBED

U-Boot Simon Glass 2 participants 3 messages Mar 22, 2019 – Mar 29, 2019 8 messages not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

A message that is not in the archive (sent off-list or not yet received): [email protected]

A message that is not in the archive (sent off-list or not yet received): [email protected]

A message that is not in the archive (sent off-list or not yet received): [email protected]

A message that is not in the archive (sent off-list or not yet received): [email protected]

A message that is not in the archive (sent off-list or not yet received): [email protected]

A message that is not in the archive (sent off-list or not yet received): [email protected]

A message that is not in the archive (sent off-list or not yet received): [email protected]

#8 lore raw

Hi,

Quoted 46 lines · Marek Vasut
Quoted 44 lines · Dalon L Westergreen
Quoted 43 lines · Marek Vasut
Quoted 42 lines · Dalon L Westergreen
Quoted 41 lines · Marek Vasut
Quoted 40 lines · Dalon L Westergreen
Quoted 29 lines · Marek Vasut
Quoted 1 line · Dalon L Westergreen

Hey Marek,

Hi,

Quoted 11 lines

A while ago, when adding the hex output required for stratix10, I enabled
CONFIG_OF_EMBED so that the spl elf included the dtb. This avoided the
--
change-address option when using objcopy to convert the u-boot-spl- dtb.bin
into
a hex file with the correct address as required by the quartus tools.

Quoted 12 lines

In any case, there is now a warning that CONFIG_OF_EMBED should only be
used
for
development and debug. I am wondering how best to resolve this issue,
should i
revert back to using objcopy with the u-boot-spl-dtb.bin, is there a way
to
have
CONFIG_OF_EMBED only apply to SPL?

Quoted 1 line

CONFIG_OF_SEPARATE is what you want.

I dont think this is what i want exactly. I was thinking of this. From 82c1d1bc6092ce40f33a04f2bc7713b0143e30a5 Mon Sep 17 00:00:00 2001
From: Dalon Westergreen <[email protected]>
Date: Wed, 20 Mar 2019 11:21:20 -0700
Subject: [PATCH 1/2] Makefile: Add target to generate hex output for combined
spl and dtb

Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines

Some architectures, Stratix10, require a hex formatted spl that combines the spl image and dtb. This adds a target to create said hex file with and offset of SPL_TEXT_BASE.

I don't really follow this thread, but you should not use CONFIG_OF_EMBED. If there is a problem with setting up the image with CONFIG_OF_SEPARATE, we should discuss it.

- Simon

Quoted 38 lines
Quoted 24 lines
Quoted 24 lines
Quoted 17 lines
Quoted 4 lines

The CONFIG_OF_SEPARATE doesn't generate a combined image anymore ? Seems like it does at least on the renesas platforms (cfr e.g. stout_defconfig, where I use exactly that).

It generates a combined binary, u-boot-spl-dtb.bin, as far as i know. The elf is not combined, so using objcopy on the elf results in a hex file without the dtb. Stratix 10 needs a combined hex file that starts at CONFIG_SPL_TEXT_BASE. This file is then combined by quartus with the fpga image. The SDM loads the spl image into the cpu's onchip ram and releases it from reset.

So what i am trying to do is get a hex file generated that is appriopriate for the quartus tools. With CONFIG_OF_EMBED, this was easy, as you just run objcopy on the elf to create the hex output. With CONFIG_OF_SEPARATE you need the combined binary to do the same. hence,

Quoted 5 lines

+OBJCOPYFLAGS_u-boot-spl-dtb.hex := -I binary -O ihex --change-

Quoted 4 lines

Review

Quoted 4 lines

address=$(CONFIG_SPL_TEXT_BASE)

(quoted diff) +3 -0
+
+spl/u-boot-spl-dtb.hex: spl/u-boot-spl-dtb.bin FORCE
+       $(call if_changed,objcopy)

Aha, right. CCing Simon, maybe he has some better idea.

Quoted 7 lines
Quoted 2 lines

Otherwise, let's add the custom target. Maybe we can add it to arch/arm/mach-socfpga instead though.

After a quick test to add the target to mach-socfpga instead of the root Makefile, it seems i would still need to modify the root Makefile to call the mach-socfpga makefile for the target in any case. If acceptable, i think it cleaner to just add the target to the root Makefile.

I think that's fine. The root Makefile is growing like dough. that needs to stop.

--
Best regards,
Marek Vasut

#9 lore raw
Quoted 62 lines · Simon Glass

Hi,

Quoted 53 lines · Marek Vasut
Quoted 52 lines · Dalon L Westergreen
Quoted 51 lines · Marek Vasut
Quoted 50 lines · Dalon L Westergreen
Quoted 49 lines · Marek Vasut
Quoted 48 lines · Dalon L Westergreen
Quoted 35 lines · Marek Vasut
Quoted 1 line · Dalon L Westergreen

Hey Marek,

Hi,

Quoted 14 lines

A while ago, when adding the hex output required for stratix10, I
enabled
CONFIG_OF_EMBED so that the spl elf included the dtb. This avoided
the
--
change-address option when using objcopy to convert the u- boot-spl-
dtb.bin
into
a hex file with the correct address as required by the quartus tools.

Quoted 15 lines

In any case, there is now a warning that CONFIG_OF_EMBED should only
be
used
for
development and debug. I am wondering how best to resolve this
issue,
should i
revert back to using objcopy with the u-boot-spl-dtb.bin, is there a
way
to
have
CONFIG_OF_EMBED only apply to SPL?

Quoted 1 line

CONFIG_OF_SEPARATE is what you want.

I dont think this is what i want exactly. I was thinking of this. From 82c1d1bc6092ce40f33a04f2bc7713b0143e30a5 Mon Sep 17 00:00:00 2001
From: Dalon Westergreen <[email protected]>
Date: Wed, 20 Mar 2019 11:21:20 -0700
Subject: [PATCH 1/2] Makefile: Add target to generate hex output for
combined
spl and dtb

Quoted 5 lines
Quoted 5 lines
Quoted 5 lines
Quoted 5 lines
Quoted 5 lines
Quoted 5 lines

Some architectures, Stratix10, require a hex formatted spl that combines
the spl image and dtb. This adds a target to create said hex file with
and offset of SPL_TEXT_BASE.

Quoted 5 lines

I don't really follow this thread, but you should not use CONFIG_OF_EMBED. If there is a problem with setting up the image with CONFIG_OF_SEPARATE, we should discuss it.

- Simon

Simon,

Did you see my patches following this email? They resolve the issues with S10 around CONFIG_OF_EMBED.

--dalon

Quoted 43 lines
Quoted 43 lines
Quoted 29 lines
Quoted 29 lines
Quoted 22 lines
Quoted 5 lines

The CONFIG_OF_SEPARATE doesn't generate a combined image anymore ? Seems
like it does at least on the renesas platforms (cfr e.g. stout_defconfig, where I use exactly that).

It generates a combined binary, u-boot-spl-dtb.bin, as far as i know. The elf is not combined, so using objcopy on the elf results in a hex file without the dtb. Stratix 10 needs a combined hex file that starts
at CONFIG_SPL_TEXT_BASE. This file is then combined by quartus with the fpga image. The SDM loads the spl image into the cpu's onchip ram and releases it from reset.

So what i am trying to do is get a hex file generated that is appriopriate
for the quartus tools. With CONFIG_OF_EMBED, this was easy, as you just
run objcopy on the elf to create the hex output. With CONFIG_OF_SEPARATE
you need the combined binary to do the same. hence,

Quoted 5 lines

+OBJCOPYFLAGS_u-boot-spl-dtb.hex := -I binary -O ihex --change-

Quoted 4 lines

Review

Quoted 4 lines

address=$(CONFIG_SPL_TEXT_BASE)

(quoted diff) +3 -0
+
+spl/u-boot-spl-dtb.hex: spl/u-boot-spl-dtb.bin FORCE
+       $(call if_changed,objcopy)

Aha, right. CCing Simon, maybe he has some better idea.

Quoted 7 lines
Quoted 2 lines

Otherwise, let's add the custom target. Maybe we can add it to arch/arm/mach-socfpga instead though.

After a quick test to add the target to mach-socfpga instead of the root Makefile, it seems i would still need to modify the root Makefile to call the mach-socfpga makefile for the target in any case. If acceptable, i think it cleaner to just add the target to the root Makefile.

I think that's fine. The root Makefile is growing like dough. that needs to stop.

--
Best regards,
Marek Vasut

#10 lore raw

HI Dalon,

Quoted 68 lines · Dalon L Westergreen
Quoted 66 lines · Simon Glass

Hi,

Quoted 53 lines · Marek Vasut
Quoted 52 lines · Dalon L Westergreen
Quoted 51 lines · Marek Vasut
Quoted 50 lines · Dalon L Westergreen
Quoted 49 lines · Marek Vasut
Quoted 48 lines · Dalon L Westergreen
Quoted 35 lines · Marek Vasut
Quoted 1 line · Dalon L Westergreen

Hey Marek,

Hi,

Quoted 14 lines

A while ago, when adding the hex output required for stratix10, I
enabled
CONFIG_OF_EMBED so that the spl elf included the dtb. This avoided
the
--
change-address option when using objcopy to convert the u- boot-spl-
dtb.bin
into
a hex file with the correct address as required by the quartus tools.

Quoted 15 lines

In any case, there is now a warning that CONFIG_OF_EMBED should only
be
used
for
development and debug. I am wondering how best to resolve this
issue,
should i
revert back to using objcopy with the u-boot-spl-dtb.bin, is there a
way
to
have
CONFIG_OF_EMBED only apply to SPL?

Quoted 1 line

CONFIG_OF_SEPARATE is what you want.

I dont think this is what i want exactly. I was thinking of this. From 82c1d1bc6092ce40f33a04f2bc7713b0143e30a5 Mon Sep 17 00:00:00 2001
From: Dalon Westergreen <[email protected]>
Date: Wed, 20 Mar 2019 11:21:20 -0700
Subject: [PATCH 1/2] Makefile: Add target to generate hex output for
combined
spl and dtb

Quoted 5 lines
Quoted 5 lines
Quoted 5 lines
Quoted 5 lines
Quoted 5 lines
Quoted 5 lines

Some architectures, Stratix10, require a hex formatted spl that combines
the spl image and dtb. This adds a target to create said hex file with
and offset of SPL_TEXT_BASE.

I don't really follow this thread, but you should not use CONFIG_OF_EMBED. If there is a problem with setting up the image with CONFIG_OF_SEPARATE, we should discuss it.

Quoted 6 lines
Quoted 1 line

- Simon

Simon,

Did you see my patches following this email? They resolve the issues with S10 around CONFIG_OF_EMBED.

No, or at least not yet. But that's good, thank you.

Regards,
Simon

[..]