Skip to contentSkip to conversation

Intel(R) MEI Driver

RFC PATCH In review Oren Weil 3 participants 5 messages Feb 10, 2011

lore
Share & tools
lore

Oren Weil

author
#0 lore raw

cover Intel(R) MEI Driver

Intel(R) Management Engine Interface (Intel(R) MEI) Driver
==========================================================

This patch contains a new Intel driver for the Linux kernel: The Intel(R) MEI Driver.

The Intel(R) MEI driver allows applications to access the Intel(R) Management Engine (Intel(R) ME) FW via the host interface.

The Intel(R) MEI driver is meant to be used mainly by the Local Manageability Service (LMS).

Note: This driver was previously called the HECI driver that was a part of the Staging area in the Kernel and was removed.

The old MEI Driver and LMS are located on openamt.org, and are not updated with the latest versions. A new version of LMS is under development and will be released soon.

This set of patches is for review purposes; the driver code for pull is in the David Woodhouse public git repository:
http://git.infradead.org/linux-2.6-mei.git

The patches is divided according to the driver files for better review process.

For more information about the MEI Driver and its usage, see:
http://software.intel.com/en-us/manageability-security/
http://software.intel.com/sites/manageability/AMT_Implementation_and_Reference_Guide/default.htm?turl=WordDocuments%2Fconnectingwiththeintelmeidriver.htm

 drivers/char/Kconfig           |   11 +
 drivers/char/Makefile          |    1 +
 drivers/char/mei/Makefile      |   23 +
 drivers/char/mei/hw.h          |  518 ++++++++++++++
 drivers/char/mei/init.c        |  837 ++++++++++++++++++++++
 drivers/char/mei/interface.c   |  478 ++++++++++++
 drivers/char/mei/interface.h   |  134 ++++
 drivers/char/mei/interrupt.c   | 1552 ++++++++++++++++++++++++++++++++++++++++
 drivers/char/mei/iorw.c        |  822 +++++++++++++++++++++
 drivers/char/mei/main.c        | 1466 +++++++++++++++++++++++++++++++++++++
 drivers/char/mei/mei.h         |  166 +++++
 drivers/char/mei/mei_version.h |   35 +
 include/linux/mei.h            |  118 +++
 13 files changed, 6161 insertions(+), 0 deletions(-)

---------------------------------------------------------------------
Intel Israel (74) Limited

This e-mail and any attachments may contain confidential material for the sole use of the intended recipient(s). Any review or distribution by others is strictly prohibited. If you are not the intended recipient, please contact the sender and delete all copies.

#1 lore raw
Quoted 4 lines · Oren Weil

Intel(R) Management Engine Interface (Intel(R) MEI) Driver
==========================================================

This patch contains a new Intel driver for the Linux kernel: The Intel(R) MEI Driver.

This patch? What patch, there is no patch here.

You sent out 13 emails with the same exact Subject line, which is not acceptable at all, and mighty confusing.

Quoted 3 lines

This set of patches is for review purposes; the driver code for pull is in the David Woodhouse public git repository:
http://git.infradead.org/linux-2.6-mei.git

No, we need these as patches, not as a pull request. Please work on fixing up your individual patches, that's the only way this is going to be accepted.

thanks,

greg k-h

#2 lore raw
Quoted 11 lines · Greg KH
Quoted 4 lines · Oren Weil

Intel(R) Management Engine Interface (Intel(R) MEI) Driver
==========================================================

This patch contains a new Intel driver for the Linux kernel: The Intel(R) MEI Driver.

This patch?  What patch, there is no patch here.

You sent out 13 emails with the same exact Subject line, which is not acceptable at all, and mighty confusing.

Quoted 7 lines
Quoted 3 lines

This set of patches is for review purposes; the driver code for pull is in the David Woodhouse public git repository:
http://git.infradead.org/linux-2.6-mei.git

No, we need these as patches, not as a pull request.  Please work on fixing up your individual patches, that's the only way this is going to be accepted.

There was a suggestion of splitting the driver into per file patches to be reviewable rather then creating gigantic driver patch. I personally would prefer the later one would happy to here any other suggestions how to split driver.

Thanks
Tomas

#3 lore raw
Quoted 16 lines · Tomas Winkler
Quoted 15 lines · Greg KH
Quoted 4 lines · Oren Weil

Intel(R) Management Engine Interface (Intel(R) MEI) Driver
==========================================================

This patch contains a new Intel driver for the Linux kernel: The Intel(R) MEI Driver.

This patch?  What patch, there is no patch here.

You sent out 13 emails with the same exact Subject line, which is not acceptable at all, and mighty confusing.

Quoted 3 lines

This set of patches is for review purposes; the driver code for pull is in the David Woodhouse public git repository:
http://git.infradead.org/linux-2.6-mei.git

Quoted 8 lines
Quoted 3 lines

No, we need these as patches, not as a pull request.  Please work on fixing up your individual patches, that's the only way this is going to be accepted.

There was a suggestion of splitting the driver into per file patches to be reviewable rather then creating gigantic driver patch. I personally would prefer the later one would happy to here any other suggestions how to split driver.

Per-file is ok, but just provide proper documentation, don't break the build, and do it the correct way, like everyone else does every day. This isn't something new people...

greg k-h

#4 lore raw
Quoted 21 lines · Greg KH
Quoted 20 lines · Tomas Winkler
Quoted 18 lines · Greg KH
Quoted 4 lines · Oren Weil

Intel(R) Management Engine Interface (Intel(R) MEI) Driver
==========================================================

This patch contains a new Intel driver for the Linux kernel: The Intel(R) MEI Driver.

This patch?  What patch, there is no patch here.

You sent out 13 emails with the same exact Subject line, which is not acceptable at all, and mighty confusing.

Quoted 3 lines

This set of patches is for review purposes; the driver code for pull is in the David Woodhouse public git repository:
http://git.infradead.org/linux-2.6-mei.git

No, we need these as patches, not as a pull request.  Please work on fixing up your individual patches, that's the only way this is going to be accepted.

Quoted 8 lines
Quoted 4 lines

There was a suggestion of splitting the driver into per file patches to be reviewable  rather then creating gigantic driver patch. I personally would prefer the later one  would happy to here any other suggestions how to split driver.

Per-file is ok, but just provide proper documentation, don't break the build, and do it the correct way, like everyone else does every day. This isn't something new people...

I was actually looking into Documentation/SubmittingDrivers and SubmittingPatches and there is much suggestion how to handle that. I'll spell it just make sure I understand correctly, we do per file patches with Kconfig + Makefile patch as last in the series so the build won't break....

Thanks
Tomas