Skip to contentSkip to conversation

NFSv3: FIx bug when using chacl and chmod to change acl

PATCH New Su Yanjun 1 participant 1 message Dec 25, 2019

Subsystems (2)
lore
Share & tools
lore

Su Yanjun

author
#0 lore raw

PATCH 1/1 NFSv3: FIx bug when using chacl and chmod to change acl

We find a bug when running test under nfsv3  as below.
1)
chacl u::r--,g::rwx,o:rw- file1
2)
chmod u+w file1
3)
chacl -l file1

We expect u::rw-, but it shows u::r--, more likely it returns the cached acl in inode.

We dig the code find that the code path is different.

chacl->..->__nfs3_proc_setacls->nfs_zap_acl_cache Then nfs_zap_acl_cache clears the NFS_INO_INVALID_ACL in NFS_I(inode)->cache_validity.

chmod->..->nfs3_proc_setattr
Because NFS_INO_INVALID_ACL has been cleared by chacl path, nfs_zap_acl_cache wont be called.

nfs_setattr_update_inode will set NFS_INO_INVALID_ACL so let it before nfs_zap_acl_cache call.

---
 fs/nfs/nfs3proc.c | 2 +-

 1 file changed, 1 insertion(+), 1 deletion(-)
fs/nfs/nfs3proc.c +0 -0
index 9eb2f1a503ab..6d736f0ac811 100644
@@ -140,9 +140,9 @@ nfs3_proc_setattr(struct dentry *dentry, struct nfs_fattr *fattr,

     nfs_fattr_init(fattr);
     status = rpc_call_sync(NFS_CLIENT(inode), &msg, 0); if (status == 0) {
+        nfs_setattr_update_inode(inode, sattr, fattr); if (NFS_I(inode)->cache_validity & NFS_INO_INVALID_ACL) nfs_zap_acl_cache(inode);
-        nfs_setattr_update_inode(inode, sattr, fattr); }
     dprintk("NFS reply setattr: %d\n", status); return status;

Signature · 1 line
2.17.1