Skip to contentSkip to conversation

Latency measurements

DISCUSSION VDA 2 participants 2 messages Oct 2, 2001 – Oct 3, 2001 1 message not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): 1001972854.2277.49.camel@phantasy

VDA

author
#1 lore raw

Hi Robert,

Quoted 10 lines · you
Quoted 10 lines

These are the longest held locks on my system (PII 233 UP, 32MB RAM, SVGA 16bit color fb console, X)
Kernel: 2.4.10 + ext3 + preemption
I am very willing to test any patches to reduce latency.

418253       BKL        1   712/tty_io.c        c01b41c5   714/tty_io.c
222609       BKL        1   712/tty_io.c        c01b41c5   697/sched.c   
152903 spin_lock        5   547/sched.c         c0114fd5   714/tty_io.c  
132422       BKL        5   712/tty_io.c        c01b41c5   714/tty_io.c  
104548       BKL        1   712/tty_io.c        c01b41c5  1380/sched.c

RL> Unfortunately there isn't much we can do about any of those locks.

RL> The locks in tty_io.c are have to be held, the fact you are using a RL> framebuffer makes it a lot worse, though. If there is an accelerated fb RL> for your video card, I would suggest that.

That is a BKL which we are trying to get rid of.
What deadlock is prevented by lock_kernel()
in tty_io.c:712?

write() call there is actually a tty->ldisc.write(). Is it possible to move lock into tty->ldisc.write() and make it a spinlock? I'd like to try, but I admit I failed to track what fn ptr is placed in ldisc.write in my case (fb console) :-(

Quoted 1 line
Quoted 1 line

222609 BKL 1 712/tty_io.c 697/sched.c

I don't quite understand how locked region can start in 712/tty_io.c and end in 697/sched.c?

This is strange too:

Quoted 1 line
Quoted 1 line

152903 spin_lock 5 547/sched.c 714/tty_io.c

spinlock? Unlocked by unlock_kernel()???

Signature · 2 lines
Best regards, VDA
mailto:[email protected]
#2 lore raw
Quoted 12 lines · VDA
Quoted 10 lines
Quoted 10 lines

These are the longest held locks on my system (PII 233 UP, 32MB RAM, SVGA 16bit color fb console, X)
Kernel: 2.4.10 + ext3 + preemption
I am very willing to test any patches to reduce latency.

418253       BKL        1   712/tty_io.c        c01b41c5   714/tty_io.c
222609       BKL        1   712/tty_io.c        c01b41c5   697/sched.c   
152903 spin_lock        5   547/sched.c         c0114fd5   714/tty_io.c  
132422       BKL        5   712/tty_io.c        c01b41c5   714/tty_io.c  
104548       BKL        1   712/tty_io.c        c01b41c5  1380/sched.c
Quoted 3 lines
Quoted 1 line
Quoted 1 line

222609 BKL 1 712/tty_io.c 697/sched.c

I don't quite understand how locked region can start in 712/tty_io.c and end in 697/sched.c?

The BKL is dropped whenever the task voluntarily blocks in the kernel. This is what you are seeing reported here. It will be reacquired when the task is rescheduled:

Quoted 3 lines

This is strange too:

Quoted 1 line
Quoted 1 line

152903 spin_lock 5 547/sched.c 714/tty_io.c

spinlock? Unlocked by unlock_kernel()???

The latency measuring code isn't always accurate in reporting the cause in this case: if it's unlocked by unlock_kernel and locked in sched.c, then it's the reacqusition of the BKL by a task that was blocked while holding the lock.

Nigel Gamble [email protected]
Mountain View, CA, USA. http://www.nrg.org/