Skip to contentSkip to conversation

bus: omap_l3_noc: Use devm_platform_get_and_ioremap_resource() in omap_l3_probe()

PATCH Superseded Markus Elfring 1 participant 2 messages Feb 5, 2024 – Feb 6, 2024

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 bus: omap_l3_noc: Use devm_platform_get_and_ioremap_resource() in omap_l3_probe()

From: Markus Elfring <[email protected]>
Date: Mon, 5 Feb 2024 07:30:56 +0100

A wrapper function is available since the commit 890cc39a879906b63912482dfc41944579df2dc6 ("drivers: provide devm_platform_get_and_ioremap_resource()").
Thus reuse existing functionality instead of keeping duplicate source code.

This issue was detected by using the Coccinelle software.

---
 drivers/bus/omap_l3_noc.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)
drivers/bus/omap_l3_noc.c +4 -2
index eb1ba6319fda..3c9e342b9e35 100644
@@ -263,8 +263,10 @@ static int omap_l3_probe(struct platform_device *pdev)
 			l3->l3_base[i] = l3->l3_base[i - 1];
 			continue;
 		}
-		res = platform_get_resource(pdev, IORESOURCE_MEM, res_idx);
-		l3->l3_base[i] = devm_ioremap_resource(&pdev->dev, res);
+
+		l3->l3_base[i] = devm_platform_get_and_ioremap_resource(pdev,
+									res_idx,
+									&res);
 		if (IS_ERR(l3->l3_base[i])) {
 			dev_err(l3->dev, "ioremap %d failed\n", i);
 			return PTR_ERR(l3->l3_base[i]);

--
2.43.0

#1 lore raw

PATCH v2 1/1 bus: omap_l3_noc: Use devm_platform_ioremap_resource() in omap_l3_probe()

From: Markus Elfring <[email protected]>
Date: Tue, 6 Feb 2024 17:01:25 +0100

A wrapper function is available since the commit 7945f929f1a77a1c8887a97ca07f87626858ff42 ("drivers: provide devm_platform_ioremap_resource()").

* Thus reuse existing functionality instead of keeping duplicate source code.

* Delete a local variable which became unnecessary with this refactoring.

This issue was transformed by using the Coccinelle software.

---

v2:
The transformation pattern was adjusted based on advices by known contributors.

Examples:
* Doug Anderson
* Geert Uytterhoeven
* Robin Murphy

 drivers/bus/omap_l3_noc.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)
drivers/bus/omap_l3_noc.c +2 -4
index eb1ba6319fda..f114dee4e937 100644
@@ -255,16 +255,14 @@ static int omap_l3_probe(struct platform_device *pdev)
 
 	/* Get mem resources */
 	for (i = 0, res_idx = 0; i < l3->num_modules; i++) {
-		struct resource	*res;
-
 		if (l3->l3_base[i] == L3_BASE_IS_SUBMODULE) {
 			/* First entry cannot be submodule */
 			BUG_ON(i == 0);
 			l3->l3_base[i] = l3->l3_base[i - 1];
 			continue;
 		}
-		res = platform_get_resource(pdev, IORESOURCE_MEM, res_idx);
-		l3->l3_base[i] = devm_ioremap_resource(&pdev->dev, res);
+
+		l3->l3_base[i] = devm_platform_ioremap_resource(pdev, res_idx);
 		if (IS_ERR(l3->l3_base[i])) {
 			dev_err(l3->dev, "ioremap %d failed\n", i);
 			return PTR_ERR(l3->l3_base[i]);

--
2.43.0