Skip to contentSkip to conversation

silly ide without proc compile fix

PATCH New Robert Love 1 participant 1 message Nov 29, 2001

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 silly ide without proc compile fix

IDE subsystem fails to compile without proc support because ide_remove_proc_entries is called but not defined. Other uses of the function are properly ifdef'ed, the following in ide-disk.c and ide-floppy.c are not.

Please apply.

Robert Love

drivers/ide/ide-disk.c +2 -0
diff -urN linux-2.4.17-pre1/drivers/ide/ide-disk.c linux/drivers/ide/ide-disk.c
@@ -856,10 +856,12 @@
 			printk (KERN_ERR "%s: cleanup_module() called while still busy\n", drive->name);
 			failed++;
 		}
 		/* We must remove proc entries defined in this module.
 		   Otherwise we oops while accessing these entries */
+#ifdef CONFIG_PROC_FS
 		if (drive->proc)
 			ide_remove_proc_entries(drive->proc, idedisk_proc);
+#endif
 	}
 	ide_unregister_module(&idedisk_module);
 }
drivers/ide/ide-floppy.c +2 -0
diff -urN linux-2.4.17-pre1/drivers/ide/ide-floppy.c linux/drivers/ide/ide-floppy.c
@@ -2071,8 +2071,10 @@
 		}
 		/* We must remove proc entries defined in this module.
 		   Otherwise we oops while accessing these entries */
+#ifdef CONFIG_PROC_FS
 		if (drive->proc)
 			ide_remove_proc_entries(drive->proc, idefloppy_proc);
+#endif
 	}
 	ide_unregister_module(&idefloppy_module);
 }