USB not processing APM suspend event properly?
Quoted 3 lines
Sending 'n'
PM_SUSPENDevents because you have 'n' listeners on/dev/apm_biosseems to be a waste of time when it could be handled more cleanly.
But do you agree that the present code does NOT do this?
The present code does not send 'n' events---only one.
Quoted 3 lines · Thomas Hood
But do you agree that the present code does NOT do this?
The present code does not send 'n' events---only one.
Ok, thinking about this obfuscated code more, it would appear so. It would also appear that when the suspend request comes from the APM bios, the ioctl() method will not call send_event() at all - instead it comes from check_events().
However, as I said previously, this is a minor issue. I'd rather the major problem was fixed.
--
Russell King ([email protected]) The developer of ARM Linux
http://www.arm.linux.org.uk/personal/aboutme.html
Quoted 7 lines · Russell King
Quoted 1 line · Thomas Hood
But do you agree that the present code does NOT do this?
Ok, thinking about this obfuscated code more, it would appear so. It would also appear that when the suspend request comes from the APM bios, the
ioctl()method will not callsend_event()at all - instead it comes fromcheck_events().
Yes.
Quoted 2 lines
However, as I said previously, this is a minor issue. I'd rather the major problem was fixed.
I agree entirely. I think that this change should be made. The question is 'When?'. Is this too big a change to make in 2.4?
Thomas