Skip to contentSkip to conversation

APM driver patch summary

DISCUSSION Thomas Hood 2 participants 2 messages Dec 18, 2001

lore
Share & tools
lore
#0 lore raw
Quoted 6 lines · Russell King

Actually you're right, it doesn't send a resume event. However, It's worse than that - it will leave all sleeping listeners still sleeping.
Try this patch instead - this should cause all listeners to get a -EIO to indicate that the suspend failed, and also get the resume event.

Hmm. You know what? I don't think the listeners really need to be sent a resume event if they are already getting an error code back! The listeners should take the error code as a cue to undo whatever they did to prepare for the suspend. The only thing is that the error code should not be EIO, since this currently means "the BIOS returned something other than APM_SUCCESS". The current code returns EAGAIN when the suspend attempt is rejected by a driver (look in do_ioctl()) and we should stick to that.

If the above is right, then in suspend() you should set "err = -EAGAIN" instead of "err = -EIO" and you should put "out:" just after the "queue_event(APM_NORMAL_RESUME, NULL);" instead of just before it.

I just checked, and apmlib 3.0.2 does not return the error code from apm_suspend(); and apmd 3.0.2 does not undo anything when apm_suspend() returns an error. These need to be fixed right away. I'll file bug reports against Debian apmd since the Debian maintainer is also the upstream maintainer -- Avery Pennarun.

Finally, think carefully about where the cli() and sti() should go.

--
Thomas

#1 lore raw
Quoted 1 line · Thomas Hood

Finally, think carefully about where the cli() and sti() should go.

I believe the cli() and sti() to be correct - you shouldn't call pm_send_all with IRQs off as it was previously. pm_send_all is a function that can sleep (check the down(&pm_devs_lock) call).

--
Russell King ([email protected]) The developer of ARM Linux
http://www.arm.linux.org.uk/personal/aboutme.html