Skip to contentSkip to conversation

ALSA not using updated lseek locking

PATCH In review Robert Love 3 participants 10 messages Feb 18, 2002 – Feb 19, 2002 Sound

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ALSA not using updated lseek locking

Manfred Spraul just pointed out to me that ALSA contains three lseek implementations, none of which use the new lseek locking rules. While it is possible the ALSA people intended for there to be no locking (as in it not being needed), I suspect the recent change was overlooked.

The lseek implementations are:

sound/core/hwdep.c :: snd_hwdep_llseek sound/core/info.c :: snd_info_entry_llseek sound/isa/gus/gus_mem_proc.c :: snd_gf1_mem_proc_llseek

snd_hwdep_llseek in hwdep.c clearly does not need locking. I suspect the other two functions do. The BKL seems the only available option.

Please apply.

Robert Love

sound/core/info.c +16 -6
diff -urN linux-2.5.5-pre1/sound/core/info.c linux/sound/core/info.c
@@ -160,31 +160,41 @@
 {
 	snd_info_private_data_t *data;
 	struct snd_info_entry *entry;
+	int ret;
 
 	data = snd_magic_cast(snd_info_private_data_t, file->private_data, return -ENXIO);
 	entry = data->entry;
+	lock_kernel();
 	switch (entry->content) {
 	case SNDRV_INFO_CONTENT_TEXT:
 		switch (orig) {
 		case 0:	/* SEEK_SET */
 			file->f_pos = offset;
-			return file->f_pos;
+			ret = file->f_pos;
+			goto out;
 		case 1:	/* SEEK_CUR */
 			file->f_pos += offset;
-			return file->f_pos;
+			ret = file->f_pos;
+			goto out;
 		case 2:	/* SEEK_END */
 		default:
-			return -EINVAL;
+			ret = -EINVAL;
+			goto out;
 		}
 		break;
 	case SNDRV_INFO_CONTENT_DATA:
-		if (entry->c.ops->llseek)
-			return entry->c.ops->llseek(entry,
+		if (entry->c.ops->llseek) {
+			ret = entry->c.ops->llseek(entry,
 						    data->file_private_data,
 						    file, offset, orig);
+			goto out;
+		}
 		break;
 	}
-	return -ENXIO;
+	ret = -ENXIO;
+out:
+	unlock_kernel();
+	return ret;
 }
 
 static ssize_t snd_info_entry_read(struct file *file, char *buffer,
sound/isa/gus/gus_mem_proc.c +3 -0
diff -urN linux-2.5.5-pre1/sound/isa/gus/gus_mem_proc.c linux/sound/isa/gus/gus_mem_proc.c
@@ -60,6 +60,7 @@
 {
 	gus_proc_private_t *priv = snd_magic_cast(gus_proc_private_t, entry->private_data, return -ENXIO);
 
+	lock_kernel();
 	switch (orig) {
 	case 0:	/* SEEK_SET */
 		file->f_pos = offset;
@@ -71,10 +72,12 @@
 		file->f_pos = priv->size - offset;
 		break;
 	default:
+		unlock_kernel();
 		return -EINVAL;
 	}
 	if (file->f_pos > priv->size)
 		file->f_pos = priv->size;
+	unlock_kernel();
 	return file->f_pos;
 }
 

_______________________________________________
Alsa-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/alsa-devel

#1 lore raw

Sequencer events not arriving guaranteed

Hello ALSA Gang,

In my system i have primarily two important alsa ports for me

64:0 is the external midi keyboard
65:0 is the wavetable synth of my creative audixy

I have written following code:

#include<alsa/asoundlib.h>
#include <stdio.h>
#include <stdlib.h>
#include <string.h>
#include <errno.h>
#include <ctype.h>
#include <getopt.h>

int main(int argc, char *argv[])

{
        int xxx;
        snd_seq_event_t ev;
        snd_seq_t *handle;
        sscanf(argv[1],"%d",&xxx);
        snd_seq_open(&handle,"hw",SND_SEQ_OPEN_DUPLEX,0);       
        bzero(&ev, sizeof(ev));
        ev.queue=SND_SEQ_QUEUE_DIRECT;
        ev.dest.client=xxx;
        ev.dest.port=0;
        ev.type = SND_SEQ_EVENT_NOTEON;
        ev.data.note.channel = 0;
        ev.data.note.note = 64;
        ev.data.note.velocity = 127;
        snd_seq_event_output_direct(handle, &ev);
        sleep(1);
        ev.type = SND_SEQ_EVENT_NOTEOFF;
        snd_seq_event_output_direct(handle, &ev);
        return 0;
}

this code works for outputting events to the wavetable, but it very seldom works for outputting to the external midi keyboard.
If I integrate this code to my application. it works sometimes for outputting to the wavetable but i have never seen it working with external midi.

Is there an inportant feature missing in my code to make its work more relyable ? (apart from error checking).
Is a queue important for reliability ?
And what about a polling descriptor ?

I am looking forward to makeing my app reliable and working

rds guenther

_______________________________________________
Alsa-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/alsa-devel

#7 lore raw

Problem with mixer settings with alsa and creative audixy

In reply to Robert Love

Hallo gang,

I have a problem with my mixer settings when listening to the sequencer(midi) in my box.
It is far to silent. I have to set my external amplifier to maximum amplification to be able to hear the tunes in an normal loudness while hearing the noise quite easy.
When I play pcm data with this settings, its terribly loud and mankind could think, i'd crash my speakers!!!!
Actually the only sliders which work is music. i hear midi music if this slider is maximum
And the Slider 'wave' also works. If i put it to minimum I can bear the volume of the pcm. All the other sliders dont show any effect althought there are so many

I have included the output of amixer to show you all the available volume controls

Simple mixer control 'Master',0
Capabilities: pvolume pswitch pswitch-joined
Playback channels: Front Left - Front Right
Limits: Playback 0 - 31
Front Left: Playback 0 [0%] [on]
Front Right: Playback 0 [0%] [on]
Simple mixer control 'Master Mono',0
Capabilities: pvolume pvolume-joined pswitch pswitch-joined Playback channels: Mono
Limits: Playback 0 - 31
Mono: Playback 0 [0%] [on]
Simple mixer control 'PCM',0
Capabilities: pvolume pswitch pswitch-joined
Playback channels: Front Left - Front Right
Limits: Playback 0 - 31
Front Left: Playback 0 [0%] [on]
Front Right: Playback 0 [0%] [on]
Simple mixer control 'Center',0
Capabilities: pvolume pvolume-joined pswitch
Playback channels: Mono
Limits: Playback 0 - 100
Mono: Playback 0 [0%] [on]
Simple mixer control 'LFE',0
Capabilities: pvolume pvolume-joined pswitch
Playback channels: Mono
Limits: Playback 0 - 100
Mono: Playback 0 [0%] [on]
Simple mixer control 'Wave',0
Capabilities: pvolume cvolume pswitch
Playback channels: Front Left - Front Right
Capture channels: Front Left - Front Right
Limits: Playback 0 - 100 Capture 0 - 100
Front Left: Playback 2 [2%] [on] Capture 2 [2%]
Front Right: Playback 2 [2%] [on] Capture 2 [2%]
Simple mixer control 'Wave Center',0
Capabilities: pvolume pvolume-joined pswitch
Playback channels: Mono
Limits: Playback 0 - 100
Mono: Playback 100 [100%] [on]
Simple mixer control 'Wave LFE',0
Capabilities: pvolume pvolume-joined pswitch
Playback channels: Mono
Limits: Playback 0 - 100
Mono: Playback 98 [98%] [on]
Simple mixer control 'Wave Surround',0
Capabilities: pvolume pswitch
Playback channels: Front Left - Front Right
Limits: Playback 0 - 100
Front Left: Playback 98 [98%] [on]
Front Right: Playback 98 [98%] [on]
Simple mixer control 'Music',0
Capabilities: pvolume cvolume pswitch
Playback channels: Front Left - Front Right
Capture channels: Front Left - Front Right
Limits: Playback 0 - 100 Capture 0 - 100
Front Left: Playback 100 [100%] [on] Capture 100 [100%] Front Right: Playback 100 [100%] [on] Capture 100 [100%]
Simple mixer control 'Line',0
Capabilities: pvolume pswitch pswitch-joined cswitch cswitch-joined
cswitch-exclusive
Capture exclusive group: 0
Playback channels: Front Left - Front Right
Capture channels: Front Left - Front Right
Limits: Playback 0 - 31
Front Left: Playback 31 [100%] [on] Capture [off]
Front Right: Playback 31 [100%] [on] Capture [off]
Simple mixer control 'CD',0
Capabilities: pvolume pswitch pswitch-joined cswitch cswitch-joined
cswitch-exclusive
Capture exclusive group: 0
Playback channels: Front Left - Front Right
Capture channels: Front Left - Front Right
Limits: Playback 0 - 31
Front Left: Playback 31 [100%] [on] Capture [off]
Front Right: Playback 31 [100%] [on] Capture [off]
Simple mixer control 'Mic',0
Capabilities: pvolume pvolume-joined pswitch pswitch-joined cswitch
cswitch-joined cswitch-exclusive
Capture exclusive group: 0
Playback channels: Mono
Capture channels: Front Left - Front Right
Limits: Playback 0 - 15
Mono: Playback 15 [100%] [on]
Front Left: Capture [off]
Front Right: Capture [off]
Simple mixer control 'Mic Boost (+20dB)',0
Capabilities: pswitch pswitch-joined
Playback channels: Mono
Mono: Playback [on]
Simple mixer control 'Video',0
Capabilities: pvolume pswitch pswitch-joined cswitch cswitch-joined
cswitch-exclusive
Capture exclusive group: 0
Playback channels: Front Left - Front Right
Capture channels: Front Left - Front Right
Limits: Playback 0 - 31
Front Left: Playback 31 [100%] [on] Capture [off]
Front Right: Playback 31 [100%] [on] Capture [off]
Simple mixer control 'Phone',0
Capabilities: pvolume pvolume-joined pswitch pswitch-joined cswitch
cswitch-joined cswitch-exclusive
Capture exclusive group: 0
Playback channels: Mono
Capture channels: Front Left - Front Right
Limits: Playback 0 - 15
Mono: Playback 15 [100%] [on]
Front Left: Capture [off]
Front Right: Capture [off]
Simple mixer control 'PC Speaker',0
Capabilities: pvolume pvolume-joined pswitch pswitch-joined Playback channels: Mono
Limits: Playback 0 - 15
Mono: Playback 15 [100%] [on]
Simple mixer control 'Aux',0
Capabilities: pvolume pswitch pswitch-joined cswitch cswitch-joined
cswitch-exclusive
Capture exclusive group: 0
Playback channels: Front Left - Front Right
Capture channels: Front Left - Front Right
Limits: Playback 0 - 31
Front Left: Playback 31 [100%] [on] Capture [on]
Front Right: Playback 31 [100%] [on] Capture [on]
Simple mixer control 'Capture',0
Capabilities: volume pswitch pswitch-joined
Playback channels: Front Left - Front Right
Capture channels: Front Left - Front Right
Limits: 0 - 15
Front Left: 15 [100%] Playback [on]
Front Right: 15 [100%] Playback [on]
Simple mixer control 'Mix',0
Capabilities: cswitch cswitch-joined cswitch-exclusive Capture exclusive group: 0
Capture channels: Front Left - Front Right
Front Left: Capture [off]
Front Right: Capture [off]
Simple mixer control 'Mix Mono',0
Capabilities: cswitch cswitch-joined cswitch-exclusive Capture exclusive group: 0
Capture channels: Front Left - Front Right

Front Left: Capture [off]
Front Right: Capture [off]
Simple mixer control 'AC97',0
Capabilities: pvolume cvolume pswitch
Playback channels: Front Left - Front Right Capture channels: Front Left - Front Right
Limits: Playback 0 - 100 Capture 0 - 100
Front Left: Playback 98 [98%] [on] Capture 98 [98%] Front Right: Playback 98 [98%] [on] Capture 98 [98%]
Simple mixer control 'Audigy CD',0
Capabilities: pvolume cvolume pswitch
Playback channels: Front Left - Front Right Capture channels: Front Left - Front Right
Limits: Playback 0 - 100 Capture 0 - 100
Front Left: Playback 100 [100%] [on] Capture 100 [100%] Front Right: Playback 100 [100%] [on] Capture 100 [100%]
Simple mixer control 'External Amplifier Power Down',0
Capabilities: pswitch pswitch-joined
Playback channels: Mono
Mono: Playback [on]
Simple mixer control 'SB Live Analog/Digital Output Jack',0
Capabilities: pswitch pswitch-joined
Playback channels: Mono
Mono: Playback [on]

Can anybody help my mixer to work or even to set to reasonably settings ??? rds guenther

_______________________________________________
Alsa-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/alsa-devel

#8 lore raw
In reply to Robert Love
Quoted 7 lines · Robert Love

Manfred Spraul just pointed out to me that ALSA contains three lseek implementations, none of which use the new lseek locking rules. While it is possible the ALSA people intended for there to be no locking (as in it not being needed), I suspect the recent change was overlooked.

The lseek implementations are:

Quoted 8 lines

sound/core/hwdep.c :: snd_hwdep_llseek sound/core/info.c :: snd_info_entry_llseek sound/isa/gus/gus_mem_proc.c :: snd_gf1_mem_proc_llseek

snd_hwdep_llseek in hwdep.c clearly does not need locking. I suspect the other two functions do. The BKL seems the only available option.

Please apply.

Sorry to reply too late, but I've not received this email before. It seems that LKML has some trouble. Only the part of patch for sound/core/info.c is valid, because llseek in gus_mem_proc.c is called from snd_info_entry_llseek(), thus the function is already protected.

Jaroslav

-----
Jaroslav Kysela <[email protected]>
Linux Kernel Sound Maintainer
ALSA Project http://www.alsa-project.org
SuSE Linux http://www.suse.com

_______________________________________________
Alsa-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/alsa-devel

#9 lore raw
Quoted 4 lines · Jaroslav Kysela

Sorry to reply too late, but I've not received this email before. It seems that LKML has some trouble. Only the part of patch for sound/core/info.c is valid, because llseek in gus_mem_proc.c is called from snd_info_entry_llseek(), thus the function is already protected.

Ah, the lseek in sound/isa/gus/gus_mem_proc.c :: snd_gf1_mem_proc_llseek is _only_ called from info.c's lseek? Then, indeed, we can remove it.

Attached patch below only adds the BKL to info.c's lseek. Thanks,

Robert Love

sound/core/info.c +16 -6
@@ -160,31 +160,41 @@
 {
 	snd_info_private_data_t *data;
 	struct snd_info_entry *entry;
+	int ret;
 
 	data = snd_magic_cast(snd_info_private_data_t, file->private_data, return -ENXIO);
 	entry = data->entry;
+	lock_kernel();
 	switch (entry->content) {
 	case SNDRV_INFO_CONTENT_TEXT:
 		switch (orig) {
 		case 0:	/* SEEK_SET */
 			file->f_pos = offset;
-			return file->f_pos;
+			ret = file->f_pos;
+			goto out;
 		case 1:	/* SEEK_CUR */
 			file->f_pos += offset;
-			return file->f_pos;
+			ret = file->f_pos;
+			goto out;
 		case 2:	/* SEEK_END */
 		default:
-			return -EINVAL;
+			ret = -EINVAL;
+			goto out;
 		}
 		break;
 	case SNDRV_INFO_CONTENT_DATA:
-		if (entry->c.ops->llseek)
-			return entry->c.ops->llseek(entry,
+		if (entry->c.ops->llseek) {
+			ret = entry->c.ops->llseek(entry,
 						    data->file_private_data,
 						    file, offset, orig);
+			goto out;
+		}
 		break;
 	}
-	return -ENXIO;
+	ret = -ENXIO;
+out:
+	unlock_kernel();
+	return ret;
 }
 
 static ssize_t snd_info_entry_read(struct file *file, char *buffer,

_______________________________________________
Alsa-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/alsa-devel

#2 lore raw

RE: Sequencer events not arriving guaranteed

In reply to Guenther Sohler
Quoted 23 lines · On 18-Feb-02 Guenther Sohler wrote:

Hello ALSA Gang,

In my system i have primarily two important alsa ports for me

64:0 is the external midi keyboard
65:0 is the wavetable synth of my creative audixy

I have written following code:

#include<alsa/asoundlib.h>
#include <stdio.h>
#include <stdlib.h>
#include <string.h>
#include <errno.h>
#include <ctype.h>
#include <getopt.h>

int main(int argc, char *argv[])

Quoted 15 lines
{
        int xxx;
        snd_seq_event_t ev;
        snd_seq_t *handle;
        sscanf(argv[1],"%d",&xxx);
        snd_seq_open(&handle,"hw",SND_SEQ_OPEN_DUPLEX,0);       
        bzero(&ev, sizeof(ev));
        ev.queue=SND_SEQ_QUEUE_DIRECT;
        ev.dest.client=xxx;
        ev.dest.port=0;
        ev.type = SND_SEQ_EVENT_NOTEON;
        ev.data.note.channel = 0;
        ev.data.note.note = 64;
        ev.data.note.velocity = 127;
        snd_seq_event_output_direct(handle, &ev);

this also causes the same error

Quoted 3 lines
        sleep(1);
        ev.type = SND_SEQ_EVENT_NOTEOFF;
        snd_seq_event_output_direct(handle, &ev);

Now I have found, that this command causes an error Nr 28 "No Space left on device" But I dont have an idea, why ?

Quoted 17 lines
        return 0;
}

this code works for outputting events to the wavetable, but it very seldom works for outputting to the external midi keyboard.
If I integrate this code to my application. it works sometimes for outputting to the wavetable but i have never seen it working with external midi.

Is there an inportant feature missing in my code to make its work more relyable
? (apart from error checking).
Is a queue important for reliability ?
And what about a polling descriptor ?

I am looking forward to makeing my app reliable and working

Quoted 7 lines

rds guenther

_______________________________________________
Alsa-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/alsa-devel

Guenther Sohler

NewLogic Technologies AG
Millennium Park 6
A-6890 Lustenau

                                           Phone: +43-5577-62000-507

E-Mail: [email protected] Fax: +43-5577-62000-988

_______________________________________________
Alsa-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/alsa-devel

#3 lore raw

RE: Sequencer events not arriving guaranteed

Quoted 40 lines · Guenther Sohler
Quoted 23 lines · On 18-Feb-02 Guenther Sohler wrote:

Hello ALSA Gang,

In my system i have primarily two important alsa ports for me

64:0 is the external midi keyboard
65:0 is the wavetable synth of my creative audixy

I have written following code:

#include<alsa/asoundlib.h>
#include <stdio.h>
#include <stdlib.h>
#include <string.h>
#include <errno.h>
#include <ctype.h>
#include <getopt.h>

int main(int argc, char *argv[])

Quoted 15 lines
{
        int xxx;
        snd_seq_event_t ev;
        snd_seq_t *handle;
        sscanf(argv[1],"%d",&xxx);
        snd_seq_open(&handle,"hw",SND_SEQ_OPEN_DUPLEX,0);
        bzero(&ev, sizeof(ev));
        ev.queue=SND_SEQ_QUEUE_DIRECT;
        ev.dest.client=xxx;
        ev.dest.port=0;
        ev.type = SND_SEQ_EVENT_NOTEON;
        ev.data.note.channel = 0;
        ev.data.note.note = 64;
        ev.data.note.velocity = 127;
        snd_seq_event_output_direct(handle, &ev);
Quoted 6 lines

this also causes the same error

Quoted 3 lines
        sleep(1);
        ev.type = SND_SEQ_EVENT_NOTEOFF;
        snd_seq_event_output_direct(handle, &ev);

Now I have found, that this command causes an error Nr 28 "No Space left on device" But I dont have an idea, why ?

It's not an error but written bytes. I found a few implementation bugs for direct event handling. The CVS code returns -ENODEV for your events. You have to subscribe the MIDI port to your port before sending events, otherwise the output rawmidi device is not opened, thus it can't accept any events.

Jaroslav

-----
Jaroslav Kysela <[email protected]>
Linux Kernel Sound Maintainer
ALSA Project http://www.alsa-project.org
SuSE Linux http://www.suse.com

_______________________________________________
Alsa-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/alsa-devel

#4 lore raw

RE: Sequencer events not arriving guaranteed

Does that mean, i have to do following:

1.) open sequencer
2.) create my own port on client
3.) subscribe sender=my port receiver=midi device
4.) create events set source to my client/port destination=midi device 5.) send events

is this the correct way of doing it ?
are there some extra things, which are not neccessary ?

Quoted 64 lines · On 19-Feb-02 Jaroslav Kysela wrote:
Quoted 40 lines · Guenther Sohler
Quoted 23 lines · On 18-Feb-02 Guenther Sohler wrote:

Hello ALSA Gang,

In my system i have primarily two important alsa ports for me

64:0 is the external midi keyboard
65:0 is the wavetable synth of my creative audixy

I have written following code:

#include<alsa/asoundlib.h>
#include <stdio.h>
#include <stdlib.h>
#include <string.h>
#include <errno.h>
#include <ctype.h>
#include <getopt.h>

int main(int argc, char *argv[])

Quoted 15 lines
{
        int xxx;
        snd_seq_event_t ev;
        snd_seq_t *handle;
        sscanf(argv[1],"%d",&xxx);
        snd_seq_open(&handle,"hw",SND_SEQ_OPEN_DUPLEX,0);
        bzero(&ev, sizeof(ev));
        ev.queue=SND_SEQ_QUEUE_DIRECT;
        ev.dest.client=xxx;
        ev.dest.port=0;
        ev.type = SND_SEQ_EVENT_NOTEON;
        ev.data.note.channel = 0;
        ev.data.note.note = 64;
        ev.data.note.velocity = 127;
        snd_seq_event_output_direct(handle, &ev);
Quoted 6 lines

this also causes the same error

Quoted 3 lines
        sleep(1);
        ev.type = SND_SEQ_EVENT_NOTEOFF;
        snd_seq_event_output_direct(handle, &ev);

Now I have found, that this command causes an error Nr 28 "No Space left on device" But I dont have an idea, why ?

It's not an error but written bytes. I found a few implementation bugs for direct event handling. The CVS code returns -ENODEV for your events. You have to subscribe the MIDI port to your port before sending events, otherwise the output rawmidi device is not opened, thus it can't accept any events.

Jaroslav

-----
Jaroslav Kysela <[email protected]>
Linux Kernel Sound Maintainer
ALSA Project http://www.alsa-project.org
SuSE Linux http://www.suse.com

Quoted 4 lines

_______________________________________________
Alsa-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/alsa-devel

Guenther Sohler

NewLogic Technologies AG
Millennium Park 6
A-6890 Lustenau

                                           Phone: +43-5577-62000-507

E-Mail: [email protected] Fax: +43-5577-62000-988

_______________________________________________
Alsa-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/alsa-devel

#5 lore raw

RE: Sequencer events not arriving guaranteed

Quoted 9 lines · Guenther Sohler

Does that mean, i have to do following:

1.) open sequencer
2.) create my own port on client
3.) subscribe sender=my port receiver=midi device
4.) create events set source to my client/port destination=midi device 5.) send events

is this the correct way of doing it ?

Yes, it is.

Quoted 1 line

are there some extra things, which are not neccessary ?

Nope.

Jaroslav

-----
Jaroslav Kysela <[email protected]>
Linux Kernel Sound Maintainer
ALSA Project http://www.alsa-project.org
SuSE Linux http://www.suse.com

_______________________________________________
Alsa-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/alsa-devel

#6 lore raw

RE: Sequencer events not arriving guaranteed

Thank you very much for your help, Jaroslav,
I always appreciate your help

regards guenther

Quoted 18 lines · On 19-Feb-02 Jaroslav Kysela wrote:
Quoted 9 lines · Guenther Sohler

Does that mean, i have to do following:

1.) open sequencer
2.) create my own port on client
3.) subscribe sender=my port receiver=midi device
4.) create events set source to my client/port destination=midi device 5.) send events

is this the correct way of doing it ?

Yes, it is.

Quoted 1 line

are there some extra things, which are not neccessary ?

Nope.

Quoted 8 lines

Jaroslav

-----
Jaroslav Kysela <[email protected]>
Linux Kernel Sound Maintainer
ALSA Project http://www.alsa-project.org
SuSE Linux http://www.suse.com

Guenther Sohler

NewLogic Technologies AG
Millennium Park 6
A-6890 Lustenau

                                           Phone: +43-5577-62000-507

E-Mail: [email protected] Fax: +43-5577-62000-988

_______________________________________________
Alsa-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/alsa-devel