Bluetooth Subsystem PC Card drivers for 2.5.27

PATCH In review Marcel Holtmann 5 participants 8 messages Jul 21, 2002 – Jul 23, 2002 Bluetooth drivers

lore

Share & tools

lore

Marcel Holtmann

author maintainer

2002-07-21 11:29 UTC #0 lore raw

PATCH 1/1 Bluetooth Subsystem PC Card drivers for 2.5.27

Hi Linus,

this patch updates the PC Card drivers of the Bluetooth subsystem. It modifies the following files:

CREDITS
MAINTAINERS
bluetooth/Config.help
drivers/bluetooth/Config.in
drivers/bluetooth/Makefile
drivers/bluetooth/bluecard_cs.c
drivers/bluetooth/bt3c_cs.c
drivers/bluetooth/dtl1_cs.c

Regards

Marcel

CREDITS +6 -0

diff -urN linux-2.5.27/CREDITS linux-2.5.27-mh/CREDITS
@@ -1337,6 +1337,12 @@
 S: Provo, Utah 84606-5607
 S: USA
 
+N: Marcel Holtmann
+E: [email protected]
+W: http://www.holtmann.org
+D: Author of the Linux Bluetooth Subsystem PC Card drivers
+S: Germany
+
 N: Rob W. W. Hooft
 E: [email protected]
 D: Shared libs for graphics-tools and for the f2c compiler

MAINTAINERS +6 -0

diff -urN linux-2.5.27/MAINTAINERS linux-2.5.27-mh/MAINTAINERS
@@ -270,6 +270,12 @@
 W:	http://bluez.sf.net
 S:	Maintained
 
+BLUETOOTH SUBSYSTEM (PC Card Drivers)
+P:	Marcel Holtmann
+M:	[email protected]
+W:	http://www.holtmann.org/linux/bluetooth/
+S:	Maintained
+
 BTTV VIDEO4LINUX DRIVER
 P:	Gerd Knorr
 M:	[email protected]

drivers/bluetooth/Config.help +14 -0

diff -urN linux-2.5.27/drivers/bluetooth/Config.help linux-2.5.27-mh/drivers/bluetooth/Config.help
@@ -62,6 +62,20 @@
   Say Y here to compile support for HCI DTL1 devices into the
   kernel or say M to compile it as module (dtl1_cs.o).
 
+HCI BT3C (PC Card) device driver
+CONFIG_BLUEZ_HCIBT3C
+  Bluetooth HCI BT3C (PC Card) driver.
+  This driver provides support for Bluetooth PCMCIA devices with
+  3Com BT3C interface:
+     3Com Bluetooth Card (3CRWB6096)
+     HP Bluetooth Card
+
+  The HCI BT3C driver uses external firmware loader program provided in
+  the BlueFW package. For more information, see <http://bluez.sf.net>.
+
+  Say Y here to compile support for HCI BT3C devices into the
+  kernel or say M to compile it as module (bt3c_cs.o).
+
 HCI BlueCard (PC Card) device driver
 CONFIG_BLUEZ_HCIBLUECARD
   Bluetooth HCI BlueCard (PC Card) driver.

drivers/bluetooth/Config.in +2 -0

diff -urN linux-2.5.27/drivers/bluetooth/Config.in linux-2.5.27-mh/drivers/bluetooth/Config.in
@@ -14,6 +14,8 @@
 
 dep_tristate 'HCI DTL1 (PC Card) driver' CONFIG_BLUEZ_HCIDTL1 $CONFIG_PCMCIA $CONFIG_BLUEZ
 
+dep_tristate 'HCI BT3C (PC Card) driver' CONFIG_BLUEZ_HCIBT3C $CONFIG_PCMCIA $CONFIG_BLUEZ
+
 dep_tristate 'HCI BlueCard (PC Card) driver' CONFIG_BLUEZ_HCIBLUECARD $CONFIG_PCMCIA $CONFIG_BLUEZ
 
 dep_tristate 'HCI VHCI (Virtual HCI device) driver' CONFIG_BLUEZ_HCIVHCI $CONFIG_BLUEZ

drivers/bluetooth/Makefile +1 -0

diff -urN linux-2.5.27/drivers/bluetooth/Makefile linux-2.5.27-mh/drivers/bluetooth/Makefile
@@ -6,6 +6,7 @@
 obj-$(CONFIG_BLUEZ_HCIVHCI)	+= hci_vhci.o
 obj-$(CONFIG_BLUEZ_HCIUART)	+= hci_uart.o
 obj-$(CONFIG_BLUEZ_HCIDTL1)	+= dtl1_cs.o
+obj-$(CONFIG_BLUEZ_HCIBT3C)	+= bt3c_cs.o
 obj-$(CONFIG_BLUEZ_HCIBLUECARD)	+= bluecard_cs.o
 
 hci_uart-y				:= hci_ldisc.o

drivers/bluetooth/bluecard_cs.c +44 ~~-53~~

341 lines not on this page · raw message

drivers/bluetooth/bt3c_cs.c +946 -0

946 lines not on this page · raw message

drivers/bluetooth/dtl1_cs.c +627 ~~-706~~

1,473 lines not on this page · raw message

Thunder from the hill

2002-07-22 03:36 UTC #1 lore raw

Hi,

Quoted 2 lines · Marcel Holtmann

this patch updates the PC Card drivers of the Bluetooth subsystem. It modifies the following files:

Please don't use EXPORT_NO_SYMBOLS where it's avoidable.

Regards, Thunder

Signature · 7 lines

(Use http://www.ebb.org/ungeek if you can't decode)
------BEGIN GEEK CODE BLOCK------
Version: 3.12
GCS/E/G/S/AT d- s++:-- a? C++$ ULAVHI++++$ P++$ L++++(+++++)$ E W-$
N--- o?  K? w-- O- M V$ PS+ PE- Y- PGP+ t+ 5+ X+ R- !tv b++ DI? !D G
e++++ h* r--- y- 
------END GEEK CODE BLOCK------

Alan Cox

2002-07-22 11:37 UTC #2 lore raw

Quoted 7 lines · Thunder from the hill

Hi,
Quoted 2 lines · Marcel Holtmann
this patch updates the PC Card drivers of the Bluetooth subsystem. It modifies the following files:
Please don't use EXPORT_NO_SYMBOLS where it's avoidable.

For 2.4 you want to use it whenever possible and a file exports no symbols. For 2.5 EXPORT_NO_SYMBOLS is the automatic default behaviour so you can lose the line

Thunder from the hill

2002-07-22 12:03 UTC #3 lore raw

Hi,

Quoted 3 lines · Alan Cox

For 2.4 you want to use it whenever possible and a file exports no symbols. For 2.5 EXPORT_NO_SYMBOLS is the automatic default behaviour so you can lose the line

This was clearly a 2.5 patch, where we currently want to get rid of EXPORT_NO_SYMBOLS.

Regards, Thunder

Signature · 7 lines

(Use http://www.ebb.org/ungeek if you can't decode)
------BEGIN GEEK CODE BLOCK------
Version: 3.12
GCS/E/G/S/AT d- s++:-- a? C++$ ULAVHI++++$ P++$ L++++(+++++)$ E W-$
N--- o?  K? w-- O- M V$ PS+ PE- Y- PGP+ t+ 5+ X+ R- !tv b++ DI? !D G
e++++ h* r--- y- 
------END GEEK CODE BLOCK------

Marcel Holtmann

author maintainer

2002-07-23 11:53 UTC #4 lore raw

In reply to Thunder from the hill

Hi,

Quoted 1 line

Please don't use EXPORT_NO_SYMBOLS where it's avoidable.

attached is the same patch without EXPORT_NO_SYMBOLS. Please apply.

Regards

Marcel

CREDITS +6 -0

diff -urN linux-2.5.27/CREDITS linux-2.5.27-mh/CREDITS
@@ -1337,6 +1337,12 @@
 S: Provo, Utah 84606-5607
 S: USA
 
+N: Marcel Holtmann
+E: [email protected]
+W: http://www.holtmann.org
+D: Author of the Linux Bluetooth Subsystem PC Card drivers
+S: Germany
+
 N: Rob W. W. Hooft
 E: [email protected]
 D: Shared libs for graphics-tools and for the f2c compiler

MAINTAINERS +6 -0

diff -urN linux-2.5.27/MAINTAINERS linux-2.5.27-mh/MAINTAINERS
@@ -270,6 +270,12 @@
 W:	http://bluez.sf.net
 S:	Maintained
 
+BLUETOOTH SUBSYSTEM (PC Card Drivers)
+P:	Marcel Holtmann
+M:	[email protected]
+W:	http://www.holtmann.org/linux/bluetooth/
+S:	Maintained
+
 BTTV VIDEO4LINUX DRIVER
 P:	Gerd Knorr
 M:	[email protected]

drivers/bluetooth/Config.help +14 -0

diff -urN linux-2.5.27/drivers/bluetooth/Config.help linux-2.5.27-mh/drivers/bluetooth/Config.help
@@ -62,6 +62,20 @@
   Say Y here to compile support for HCI DTL1 devices into the
   kernel or say M to compile it as module (dtl1_cs.o).
 
+HCI BT3C (PC Card) device driver
+CONFIG_BLUEZ_HCIBT3C
+  Bluetooth HCI BT3C (PC Card) driver.
+  This driver provides support for Bluetooth PCMCIA devices with
+  3Com BT3C interface:
+     3Com Bluetooth Card (3CRWB6096)
+     HP Bluetooth Card
+
+  The HCI BT3C driver uses external firmware loader program provided in
+  the BlueFW package. For more information, see <http://bluez.sf.net>.
+
+  Say Y here to compile support for HCI BT3C devices into the
+  kernel or say M to compile it as module (bt3c_cs.o).
+
 HCI BlueCard (PC Card) device driver
 CONFIG_BLUEZ_HCIBLUECARD
   Bluetooth HCI BlueCard (PC Card) driver.

drivers/bluetooth/Config.in +2 -0

diff -urN linux-2.5.27/drivers/bluetooth/Config.in linux-2.5.27-mh/drivers/bluetooth/Config.in
@@ -14,6 +14,8 @@
 
 dep_tristate 'HCI DTL1 (PC Card) driver' CONFIG_BLUEZ_HCIDTL1 $CONFIG_PCMCIA $CONFIG_BLUEZ
 
+dep_tristate 'HCI BT3C (PC Card) driver' CONFIG_BLUEZ_HCIBT3C $CONFIG_PCMCIA $CONFIG_BLUEZ
+
 dep_tristate 'HCI BlueCard (PC Card) driver' CONFIG_BLUEZ_HCIBLUECARD $CONFIG_PCMCIA $CONFIG_BLUEZ
 
 dep_tristate 'HCI VHCI (Virtual HCI device) driver' CONFIG_BLUEZ_HCIVHCI $CONFIG_BLUEZ

drivers/bluetooth/Makefile +1 -0

diff -urN linux-2.5.27/drivers/bluetooth/Makefile linux-2.5.27-mh/drivers/bluetooth/Makefile
@@ -6,6 +6,7 @@
 obj-$(CONFIG_BLUEZ_HCIVHCI)	+= hci_vhci.o
 obj-$(CONFIG_BLUEZ_HCIUART)	+= hci_uart.o
 obj-$(CONFIG_BLUEZ_HCIDTL1)	+= dtl1_cs.o
+obj-$(CONFIG_BLUEZ_HCIBT3C)	+= bt3c_cs.o
 obj-$(CONFIG_BLUEZ_HCIBLUECARD)	+= bluecard_cs.o
 
 hci_uart-y				:= hci_ldisc.o

drivers/bluetooth/bluecard_cs.c +42 ~~-53~~

336 lines not on this page · raw message

drivers/bluetooth/bt3c_cs.c +944 -0

944 lines not on this page · raw message

drivers/bluetooth/dtl1_cs.c +625 ~~-706~~

1,469 lines not on this page · raw message

Ingo Molnar

2002-07-23 12:23 UTC #5 lore raw

Quoted 2 lines

Please don't use EXPORT_NO_SYMBOLS where it's avoidable.

why?

other than since it's the default, there's no need to define it in 2.5 kernels.

Ingo

Thunder from the hill

2002-07-23 12:26 UTC #6 lore raw

Hi,

Quoted 1 line · Ingo Molnar

why?

Because once it became standard, we want to remove it somewhen. It's sometimes a bit ridiculous when you read it...

Regards, Thunder

Signature · 7 lines

(Use http://www.ebb.org/ungeek if you can't decode)
------BEGIN GEEK CODE BLOCK------
Version: 3.12
GCS/E/G/S/AT d- s++:-- a? C++$ ULAVHI++++$ P++$ L++++(+++++)$ E W-$
N--- o?  K? w-- O- M V$ PS+ PE- Y- PGP+ t+ 5+ X+ R- !tv b++ DI? !D G
e++++ h* r--- y- 
------END GEEK CODE BLOCK------

Dave Jones

2002-07-23 12:57 UTC #7 lore raw

Quoted 2 lines · Thunder from the hill

Because once it became standard, we want to remove it somewhen. It's sometimes a bit ridiculous when you read it...

Completely removing it means driver maintainers need to keep separate 2.4/2.6 versions of their drivers. The extra EXPORT_NO_SYMBOLS is harmless, and allows single source, multi kernel version drivers.

Dave

Signature · 2 lines

| Dave Jones.        http://www.codemonkey.org.uk
| SuSE Labs