Skip to contentSkip to conversation

fix for pci_enable_device in 2.4.19ac3

DISCUSSION Jeremy Fitzhardinge 1 participant 1 message Aug 5, 2002

lore
Share & tools
lore
#0 lore raw

I found my tulip driver was complaining about not being able to enable the device. Turns out this was the problem:

==== //depot/linux/2.4ac/drivers/pci/pci.c#3 - /home/jeremy/p4/linux/2.4ac/drivers/pci/pci.c ==== @@ -389,7 +389,7 @@
int
pci_enable_device(struct pci_dev *dev)
{
- pci_enable_device_bars(dev, 0x3F);
+ return pci_enable_device_bars(dev, 0x3F);
}

/**

I guess nobody else checks their error returns (or it just happened to always return 0).

J

[ sorry about the resend; forgot to turn off HTML ]