Skip to contentSkip to conversation

Possible null pointer in drivers/serial/core.c

PATCH New Paul Larson 1 participant 1 message Oct 9, 2002

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Possible null pointer in drivers/serial/core.c

In core.c:uart_startup() line 210 I found a possible null pointer dereference at line 210:
if (info->tty->termios->c_cflag & CBAUD)

There are other things around that same area that do the checking for info->tty before dereferencing it, so either they are unneeded, or this one needs a check too.

Thanks,
Paul Larson
--------------------

drivers/serial/core.c +1 -1
@@ -207,7 +207,7 @@
 			 * Setup the RTS and DTR signals once the
 			 * port is open and ready to respond.
 			 */
-			if (info->tty->termios->c_cflag & CBAUD)
+			if (info->tty && (info->tty->termios->c_cflag & CBAUD))
 				uart_set_mctrl(port, TIOCM_RTS | TIOCM_DTR);
 		}