Skip to contentSkip to conversation

Broken Cache Flushing in arch/parisc/kernel/signal.c.??

parisc-linux Ryan Bradetich 4 participants 4 messages Nov 13, 2002

lore
Share & tools
lore
#0 lore raw

Hello parisc-linux hackers,

I spent the evening tracking down why the serial mux failed to start init and I kept getting the cow message on 2.5.47...and why it worked for 2.5.46-pa7. After re-merging all the cvs commits in the last 4 days, I finally tracked the problem down to this chunk of code from arch/parisc/kernel/singal.c:

Index: arch/parisc/kernel/signal.c
===================================================================
RCS file: /var/cvs/linux-2.5/arch/parisc/kernel/signal.c,v retrieving revision 1.6

parisc/kernel/signal.c +13 -0
diff -u -p -r1.6 signal.c
@@ -308,8 +308,21 @@ setup_rt_frame(int sig, struct k_sigacti
 	}
 #endif
 
+#if CACHE_FLUSHING_IS_NOT_BROKEN
 	flush_icache_range((unsigned long) &frame->tramp[0],
 			   (unsigned long) &frame->tramp[4]);
+#else
+       /* It should *always* be cache line-aligned, but the compiler
+           sometimes screws up. */
+       asm volatile("fdc 0(%%sr3,%0)\n\t"
+                    "fdc %1(%%sr3,%0)\n\t"
+                    "sync\n\t"
+                    "fic 0(%%sr3,%0)\n\t"
+                    "fic %1(%%sr3,%0)\n\t"
+                    "sync\n\t"
+                    : : "r" (frame->tramp), "r" (L1_CACHE_BYTES));
+#endif
+
 	rp = (unsigned long) frame->tramp;
 
 	if (err)

This patch is needed to restore the functionality of the 2.5.46 kernel so the Serial Mux, pdc console, etc will boot on the K460, etc. I did not want to re-commit this patch because it is ugly, and it would be nice to figure out how to solve this problem properly.

Any thoughts, suggestions, etc?

Thanks!

- Ryan

#1 lore raw
Quoted 5 lines
parisc/kernel/signal.c +3 -0
+#if CACHE_FLUSHING_IS_NOT_BROKEN
 	flush_icache_range((unsigned long) &frame->tramp[0],
 			   (unsigned long) &frame->tramp[4]);
+#else
+       /* It should *always* be cache line-aligned, but the compiler

parisc/kernel/signal.c setup_rt_frame(int sig, struct k_sigacti · line 325

Quoted 10 lines
parisc/kernel/signal.c +10 -0
+           sometimes screws up. */
+       asm volatile("fdc 0(%%sr3,%0)\n\t"
+                    "fdc %1(%%sr3,%0)\n\t"
+                    "sync\n\t"
+                    "fic 0(%%sr3,%0)\n\t"
+                    "fic %1(%%sr3,%0)\n\t"
+                    "sync\n\t"
+                    : : "r" (frame->tramp), "r" (L1_CACHE_BYTES));
+#endif
+

<sigh>
this is partly my fault, since i thought we have unbroken cache flushing and asked thibaut to check this in... now i see that the original code flushes sr3 space, but flush_icache_range() flushes the kernel space... oops!

perhaps we should just check the old code back in for now?

randolph

Signature · 3 lines
Randolph Chung
Debian GNU/Linux Developer, hppa/ia64 ports
http://www.tausq.org/
#2 lore raw
Quoted 6 lines · Randolph Chung

this is partly my fault, since i thought we have unbroken cache flushing and asked thibaut to check this in... now i see that the original code flushes sr3 space, but flush_icache_range() flushes the kernel space... oops!

perhaps we should just check the old code back in for now?

Can we use
void flush_icache_user_range(struct vm_area_struct *vma,
struct page *page, unsigned long addr, int len)
? I'm not sure where we'd get the struct page from, though.

Signature · 1 line
Revolutions do not require corporate support.
#3 lore raw

Le mercredi, 13 nov 2002, =E0 13:28 Europe/Paris, Matthew Wilcox a =E9crit= :

Quoted 4 lines · Randolph Chung
Quoted 3 lines

this is partly my fault, since i thought we have unbroken cache=20 flushing
and asked thibaut to check this in... now i see that the original =

code

Quoted 9 lines
Quoted 5 lines

flushes sr3 space, but flush_icache_range() flushes the kernel=20 space...
oops!

perhaps we should just check the old code back in for now?

Can we use
void flush_icache_user_range(struct vm_area_struct *vma,
struct page *page, unsigned long addr, int =

len)

Quoted 1 line

? I'm not sure where we'd get the struct page from, though.

I reverted to the previous version until we find that out. HTH,

Thibaut VARENE
The PA/Linux ESIEE Team
http://pateam.esiee.fr/=