Skip to contentSkip to conversation

remove warnings/errors from arch/i386/kernel/suspend_asm.S

PATCH In review Andy Pfiffer 2 participants 2 messages Dec 11, 2002

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 remove warnings/errors from arch/i386/kernel/suspend_asm.S

Some earlier versions of gas (2.10.91 specifically) will error out on the "movw %eax,%ds" in arch/i386/kernel/suspend_asm.S. gas 2.11.92 complains but continues.

Here is a trivial patch that eliminates two warnings.

# This is a BitKeeper generated patch for the following project:
# Project Name: Linux kernel tree
# This patch format is intended for GNU patch command version 2.5 or higher. # This patch includes the following deltas:
# ChangeSet 1.865 -> 1.866
# arch/i386/kernel/suspend_asm.S 1.2 -> 1.3
#
# The following is the BitKeeper ChangeSet Log
# --------------------------------------------
# 02/12/11 [email protected] 1.866
# Correct syntax to remove assembler warnings and errors.
# --------------------------------------------
#

arch/i386/kernel/suspend_asm.S +3 -3
diff -Nru a/arch/i386/kernel/suspend_asm.S b/arch/i386/kernel/suspend_asm.S
@@ -6,7 +6,7 @@
 #include <asm/segment.h>
 #include <asm/page.h>
 
-ENTRY(do_magic):
+ENTRY(do_magic)
 	pushl %ebx
 	cmpl $0,8(%esp)
 	jne .L1450
@@ -66,7 +66,7 @@
 .L1453:
 	movl $104,%eax
 
-	movw %eax, %ds
+	movw %ax, %ds
 	movl saved_context_esp, %esp
 	movl saved_context_ebp, %ebp
 	movl saved_context_eax, %eax
@@ -88,4 +88,4 @@
 loop2:
        .quad 0
        .previous
-	
\ No newline at end of file
+
#1 lore raw

Hi!

Quoted 5 lines

Some earlier versions of gas (2.10.91 specifically) will error out on the "movw %eax,%ds" in arch/i386/kernel/suspend_asm.S. gas 2.11.92 complains but continues.

Here is a trivial patch that eliminates two warnings.

Is it against 2.5.51? If so forward it to trivial patch monkey, so it gets applied [I have it in my tree, already].

Pavel

Signature · 2 lines
Casualities in World Trade Center: ~3k dead inside the building,
cryptography in U.S.A. and free speech in Czech Republic.