add_mtd_device_full

Hello,

This patch adds a function add_mtd_device_full which works the same as add_mtd_device except it allows you to request a particular minor number for the new device.

I wanted this because on our boards we have Flash, SRAM and BIOS all accessible via MTD, unfortunately the minor number of the SRAM and BIOS devices can change depending on how many partitions exist in the main Flash, and the BIOS minor number can additionally change depending on if the board has SRAM fitted or not etc. I would much prefer to be able to say that SRAM would always be mtd14 and BIOS would be mtd15.

It is also possible (and I have done this :-( ) that when booting from a HDD or CDROM you modprobe the BIOS mapping module before the Flash mapping module and happily overwrite the BIOS (on mtd0) thinking it is the boot partition on the flash (which is normally mtd0).

What are the chances of this being rolled into the main MTD distribution?

I've also attached mtd.ram.erase.patch which I sent ages ago which is needed to mount JFFS2 on an SRAM (map_ram) device.

Ian.

Ian Campbell
Design Engineer

Arcom Control Systems Ltd,
Clifton Road,
Cambridge CB1 7EA
United Kingdom

Tel: +44 (0)1223 403465
E-Mail: [email protected]
Web: http://www.arcom.com


________________________________________________________________________
This email has been scanned for all viruses by the MessageLabs SkyScan
service. For more information on a proactive anti-virus service working
around the clock, around the globe, visit http://www.messagelabs.com
________________________________________________________________________

? mtd.ram.erase.patch
? drivers/mtd/chips/.map_ram.c.swp
Index: drivers/mtd/chips/map_ram.c =========================================?rom [email protected] Wed Feb 5 11:42:31 2003
From: [email protected] (Ian Campbell)
Date: 05 Feb 2003 11:42:31 +0000
Subject: [PATCH] add_mtd_device_full
Message-ID: <1044445351.12802.1558.camel@LinuxDev>

Hello,

This patch adds a function add_mtd_device_full which works the same as add_mtd_device except it allows you to request a particular minor number for the new device.

I wanted this because on our boards we have Flash, SRAM and BIOS all accessible via MTD, unfortunately the minor number of the SRAM and BIOS devices can change depending on how many partitions exist in the main Flash, and the BIOS minor number can additionally change depending on if the board has SRAM fitted or not etc. I would much prefer to be able to say that SRAM would always be mtd14 and BIOS would be mtd15.

It is also possible (and I have done this :-( ) that when booting from a HDD or CDROM you modprobe the BIOS mapping module before the Flash mapping module and happily overwrite the BIOS (on mtd0) thinking it is the boot partition on the flash (which is normally mtd0).

What are the chances of this being rolled into the main MTD distribution?

I've also attached mtd.ram.erase.patch which I sent ages ago which is needed to mount JFFS2 on an SRAM (map_ram) device.

Ian.

Ian Campbell
Design Engineer

Arcom Control Systems Ltd,
Clifton Road,
Cambridge CB1 7EA
United Kingdom

Tel: +44 (0)1223 403465
E-Mail: [email protected]
Web: http://www.arcom.com


________________________________________________________________________
This email has been scanned for all viruses by the MessageLabs SkyScan
service. For more information on a proactive anti-virus service working
around the clock, around the globe, visit http://www.messagelabs.com
________________________________________________________________________

? mtd.ram.erase.patch
? drivers/mtd/chips/.map_ram.c.swp
Index: drivers/mtd/chips/map_ram.c
===================================================================
RCS file: /home/cvs/mtd/drivers/mtd/chips/map_ram.c,v retrieving revision 1.14

diff -u -r1.14 map_ram.c
@@ -107,6 +107,8 @@
 	for (i=0; i<instr->len; i++)
 		map->write8(map, 0xFF, instr->addr + i);
 
+	instr->state = MTD_ERASE_DONE;
+
 	if (instr->callback)
 		instr->callback(instr);
 

Index: drivers//mtd/mtdcore.c
===================================================================
RCS file: /home/cvs/mtd/drivers/mtd/mtdcore.c,v
retrieving revision 1.34

Index: drivers//mtd/chips/map_ram.c
===================================================================
RCS file: /home/cvs/mtd/drivers/mtd/chips/map_ram.c,v retrieving revision 1.14

diff -u -b -B -w -p -u -r1.14 map_ram.c
@@ -107,6 +107,8 @@ static int mapram_erase (struct mtd_info
 	for (i=0; i<instr->len; i++)
 		map->write8(map, 0xFF, instr->addr + i);
 
+	instr->state = MTD_ERASE_DONE;
+
 	if (instr->callback)
 		instr->callback(instr);