Skip to contentSkip to conversation

another SCSI sync

DISCUSSION Linus Torvalds 2 participants 2 messages Feb 22, 2003 1 message not in the archive SCSI

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): 1045932775.1946.18.camel@mulgrave

#1 lore raw

This fails with

	drivers/built-in.o(.init.text+0x88df): In function `init_scsi':
	: undefined reference to `scsi_exit_procfs'
	drivers/built-in.o(.init.text+0x88e4): In function `init_scsi':
	: undefined reference to `scsi_exit_queue'
	make: *** [.tmp_vmlinux1] Error 1

for me.

They are marked __exit, which means that they end up being marked unused _and_ in a segment that doesn't ever get loaded for built-in stuff (since clearly the built-in kernel can never unload).

In general, it is just illegal to call an __exit function from something that isn't __exit itself. And these functions are called from __init function too.

Please fix. In the meantime, my fix is to remove the two bogus "__exit" notifiers, and wondering to myself how the hell this ever worked for any of you guys.

Linus

#2 lore raw
Quoted 11 lines · Linus Torvalds

They are marked __exit, which means that they end up being marked unused _and_ in a segment that doesn't ever get loaded for built-in stuff (since clearly the built-in kernel can never unload).

In general, it is just illegal to call an __exit function from something that isn't __exit itself. And these functions are called from __init function too.

Please fix. In the meantime, my fix is to remove the two bogus "__exit" notifiers, and wondering to myself how the hell this ever worked for any of you guys.

Okay, this was my fault. It seems the old toolchain on SuSE 8.0 (gcc 2.95-based) doesn't seem to notice this yet. Your fix is correct, there's no other fixups needed.