VIA 82xx broken by 0.9.0rc7 patch
At 24 Mar 2003 10:40:03 -0500,
Quoted 18 lines · Kristofer T. Karas
Hello Takashi,
I upgrade my via-82xx driver from 0.9.0rc6 to 0.9.2 and found that the sound quality patch (applied somewhere in the 0.9.0rc1 timeframe) seemed to have been lost/reverted. Working backwards to find the point at which things broke, it appears to be your kernel driver patch made in mid December (between 0.9.0rc6 and 0.9.0rc7). I browsed alsa-devel and alsa-users to see if this had been reported previously, but I have seen little other than random bug-reports on alsa-user (most recently one about "Noise").
Although the 8233 driver "functioned" throughout most of 0.9.0beta..., sound quality was dreadful. The output seemed to be a combination of being clipped and passed through a flanger. The beat frequency of the "flanger" effect could be reduced to tolerable levels if the input sampling frequency was set to 48KHz rather than 44.1 or whatever.
Quoted 6 lines
Then, sometime in the 0.9.0rc1 timeframe (sorry, I don't remember just which version) a patch to 8233 fixed the problem. That is, until 0.9.0rc7.
Since you're the submitter of the patch in question, I thought I'd send this report your way...
could you try the attached patch? it might solve the problem if you mentioned about OSS applications.
except for such a hidden bug, the difference between 0.9.0rc6 and rc7 is the use of the DSX channels as the first pcm device. if the above patch doesn't fix, please try to use hw:0,1 (for alsa native) or /dev/adsp (for oss) as the sound device.
if the second pcm device works, then your chip model doesn't support DSX channels well. maybe it's better to put the module option to specify the chip model explicitly...
Takashi
At 26 Mar 2003 16:17:46 -0500,
Quoted 27 lines · Kristofer T. Karas
Quoted 2 lines · Takashi Iwai
could you try the attached patch? it might solve the problem if you mentioned about OSS applications.
Hi Takashi,
The patch made no obvious difference (tried it on 0.9.2).
Quoted 4 lines
except for such a hidden bug, the difference between 0.9.0rc6 and rc7 is the use of the DSX channels as the first pcm device. if the above patch doesn't fix, please try to use hw:0,1 (for alsa native) or
/dev/adsp(for oss) as the sound device.Tried, and the results are indeed interesting. FWIW, I used Sarah Brightman's "Eden" as my reference sample, as it has some extended notes that let you pick up aberrations. I used 'play' (sox) and 'madplay' to reproduce via OSS, and 'aplay' for ALSA native.
0.9.0rc6 was my reference driver, to which I attribute a "perfect" score (though the S/N ratio is admitedly poor due to background noise on the motherboard in combination with poor shielding). No difference in reproduction regardless of output device or client program.
0.9.2,
/dev/dsp, 'play': Output chopped/clipped irregularly and at high speed, lots of artifacts.
Quoted 6 lines
0.9.2, ALSA/aplay: Nearly identical to above. Subjective feel is that artifacts/clipping/distortions occur at a slightly higher rate (rate conversion?).
0.9.2,
/dev/dsp, 'madplay': As with 'play' and/dev/dsp, but seems to be passed though a low-pass filter with a cutoff of several hundred Hz.
hmm, then apparently the DSX channel cannot be used properly on your chip model. do you get the kernel debug messages?
just to be sure: please prepare the WAV files (16bit 2ch) with different sample rates (44100 and 48000 would be enough). compile the driver with POINTER_DEBUG enabled (around line 63), install it, and and play the samples above via aplay -Dhw:0. then check any kernel debug messages.
Quoted 8 lines
0.9.2,
/dev/adsp, 'play' and/or 'madplay': Nearly perfect output. The test sample was effectively identical to that under 0.9.0rc6 until the final 20 seconds of the music sample, when some clipping occurred. Repeated the A/B comparison several times, and the clipping (though soft and unobtrusive) was specific to 0.9.2 only. Subjectively, I thought I heard an accentuation of the high frequencies under 0.9.2 not heard under 0.9.0rc6 (a particular sharpness to the sung "S" sound), but am not positive; the difference was quite minor if there was one.
do you see any kernel messages such as "invalid via82xx_cur_ptr"? also, please try the driver with POINTER_DEBUG enabled and check the kernel messages.
the only obvious difference from 0.9.0rc6 is the check of the pointer callback, and if it's the cause, it should put any debug messages.
Quoted 8 lines
0.9.0, hw:0,1: Same as for 0.9.0
/dev/adsp; nearly perfect output again, soft clipping at tail end of sample, etc.Quoted 3 lines
if the second pcm device works, then your chip model doesn't support DSX channels well. maybe it's better to put the module option to specify the chip model explicitly...
Quoted 5 lines
I'm surprised that 0.9.0rc6 would correctly identify the specific hardware but not 0.9.0. The aberations made by 0.9.2 are the same as those made by 0.9.0rc1 or 0.9.0betaN. (Weenie: Even after a short perusal of the module init code, it wasn't obvious what I would pass in to specify the chipset, or exactly which chipset.)
no, the 0.9.2 driver detects the exact chip model but it assumes that your chip supports DSX channels, which looks incorrect. please show the entry of /proc/asound/cards. it includes the revision number.
thanks,
Takashi
-------------------------------------------------------
This SF.net email is sponsored by:
The Definitive IT and Networking Event. Be There! NetWorld+Interop Las Vegas 2003 -- Register today!
http://ads.sourceforge.net/cgi-bin/redirect.pl?keyn0001en