Request for reviews for 4.4-st58, 4.4-cip93
Hi!
Here's the manual backports to review for the next 4.4 release which, as always, can be found in https://git.kernel.org/pub/scm/linux/kernel/git/cip/linux-cip.git/log/?h=linux-4.4.y-st-rc
810047a5a2d59 xhci: Fix Link TRB DMA in command ring stopped completion event 514f5ac9c1666 selinux: improve error checking in sel_write_load() a2b280ab0ae0b nilfs2: fix kernel bug due to missing clearing of buffer delay flag 3bcf6988dfd1a drm/amd: Guard against bad data for ATIF ACPI method 86191495e89b8 RDMA/cxgb4: Fix RDMA_CM_EVENT_UNREACHABLE error for iWARP 3ab089df2d674 nilfs2: propagate directory read errors from nilfs_find_entry() f39491c638d21 CDC-NCM: avoid overflow in sanity checking56c693c3da940 net: ipv6: ensure we call ipv6_mc_down() at most once 0544747431c07 tcp: fix tcp_enter_recovery() to zero retrans_stamp when it's safe 2d384ff2d55e3 SUNRPC: Fix integer overflow in decode_rc_list() 2e666ea559b34 rtc: at91sam9: fix OF node leak in probe() error path bec0bfe9b401f ext4: update orig_path in ext4_find_extent()e6bc59e0c89e7 ext4: fix slab-use-after-free in ext4_split_extent_at() e01afdabeaffc ext4: avoid ext4_error()'s caused by ENOMEM in the truncate path 1ac1d775e3a60 aoe: fix the potential use-after-free problem in more places f164fee72b643 ocfs2: reserve space for inline xattr before attaching reflink tree bfe7a9a5b48c4 ext4: fix i_data_sem unlock order in ext4_ind_migrate() 49dd4925f15ef ACPI: EC: Do not release locks during operation region accesses 19e2758d6c70e sctp: set sk_state back to CLOSED if autobind fails in sctp_listen_start 43c8bfae4c2a5 fs: Fix file_set_fowner LSM hook inconsistencies 58779420cf48b netfilter: nf_reject_ipv6: fix nf_reject_ip6_tcphdr_put() 8b7c662950e81 ntb: intel: Fix the NULL vs IS_ERR() bug for debugfs_create_dir() 66b2e36a28fce RDMA/cxgb4: Added NULL check for lookup_atid32e5edc296e1a nilfs2: fix potential null-ptr-deref in nilfs_btree_insert() 6832f76bf7d42 ext4: avoid OOB when system.data xattr changes underneath the filesystem 89278fdddd51e kthread: fix task state in kthread worker if being frozen 0994d75c1648c kthread: add kthread_work tracepointscad9f4314a05e drm/rockchip: vop: Allow 4096px width scaling 65dc79e557302 gpio: prevent potential speculation leaks in gpio_device_get_desc()
There's also a fix for a previous backport:
c4a2255b27149 nilfs2: fix incorrect use of nilfs_error()
Thank you for having a look.
CU
Uli
Hi!
Quoted 2 lines
Here's the manual backports to review for the next 4.4 release which, as always, can be found in https://git.kernel.org/pub/scm/linux/kernel/git/cip/linux-cip.git/log/?h=linux-4.4.y-st-rc
Thanks for series, most look good (and I'm still reviewing them), but I have few comments:
Quoted 1 line
58779420cf48bnetfilter:nf_reject_ipv6: fixnf_reject_ip6_tcphdr_put()
Ported patch is very different from what mainline has and changelog describes. We probably don't have good way to handle this, maybe we should have fixes-same-bug-as: xxx header or something like that.
Quoted 1 line
0994d75c1648ckthread: addkthread_worktracepoints
These are simply added tracepoints. I guess they can be useful, but I'd hardly call it a bug when they are not there.
Quoted 1 line
cad9f4314a05edrm/rockchip: vop: Allow 4096px width scaling
I guess noone uses this in 4.4, but this simply enables wider range of configurations, and I'm pretty sure noone tested it.
Best regards,
Pavel
Signature · 2 lines
DENX Software Engineering GmbH, Managing Director: Erika Unter HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Hi Ulrich,
Quoted 51 lines
-----Original Message-----
From: Ulrich Hecht <[email protected]>
Sent: Monday, November 18, 2024 4:01 PM
To: [email protected]; [email protected]; iwamatsu nobuhiro(岩松 信 洋 ○DITC□DIT○OST) <[email protected]>
Subject: Request for reviews for 4.4-st58, 4.4-cip93Hi!
Here's the manual backports to review for the next 4.4 release which, as always, can be found in
https://git.kernel.org/pub/scm/linux/kernel/git/cip/linux-cip.git/log/?h=linu
x-4.4.y-st-rc
810047a5a2d59xhci: Fix Link TRB DMA in command ring stopped completion event514f5ac9c1666selinux: improve error checking insel_write_load()a2b280ab0ae0bnilfs2: fix kernel bug due to missing clearing of buffer delay flag3bcf6988dfd1adrm/amd: Guard against bad data for ATIF ACPI method86191495e89b8RDMA/cxgb4: FixRDMA_CM_EVENT_UNREACHABLEerror
for iWARP3ab089df2d674nilfs2: propagate directory read errors fromnilfs_find_entry()f39491c638d21CDC-NCM: avoid overflow in sanity checking56c693c3da940net: ipv6: ensure we callipv6_mc_down()at most once0544747431c07tcp: fixtcp_enter_recovery()to zeroretrans_stampwhen it's safe2d384ff2d55e3SUNRPC: Fix integer overflow indecode_rc_list()2e666ea559b34rtc: at91sam9: fix OF node leak inprobe()error pathbec0bfe9b401fext4: updateorig_pathinext4_find_extent()e6bc59e0c89e7ext4: fix slab-use-after-free inext4_split_extent_at()e01afdabeaffcext4: avoid ext4_error()'s caused by ENOMEM in the truncate path1ac1d775e3a60aoe: fix the potential use-after-free problem in more placesf164fee72b643ocfs2: reserve space for inline xattr before attaching reflink treebfe7a9a5b48c4ext4: fixi_data_semunlock order inext4_ind_migrate()49dd4925f15efACPI: EC: Do not release locks during operation region accesses19e2758d6c70esctp: setsk_stateback to CLOSED if autobind fails insctp_listen_start43c8bfae4c2a5fs: Fixfile_set_fownerLSM hook inconsistencies58779420cf48bnetfilter:nf_reject_ipv6: fixnf_reject_ip6_tcphdr_put()8b7c662950e81ntb: intel: Fix the NULL vsIS_ERR()bug fordebugfs_create_dir()66b2e36a28fceRDMA/cxgb4: Added NULL check forlookup_atid32e5edc296e1anilfs2: fix potential null-ptr-deref innilfs_btree_insert()6832f76bf7d42ext4: avoid OOB when system.data xattr changes underneath the filesystem89278fdddd51ekthread: fix task state in kthread worker if being frozen0994d75c1648ckthread: addkthread_worktracepointscad9f4314a05edrm/rockchip: vop: Allow 4096px width scaling65dc79e557302gpio: prevent potential speculation leaks ingpio_device_get_desc()
Quoted 5 lines
There's also a fix for a previous backport:
c4a2255b27149nilfs2: fix incorrect use ofnilfs_error()Thank you for having a look.
Thanks for your work! I reviewed these commits. There doesn't seem to be any problem without Pavel's comment. BTW, could you also consider applying the following patches? These two patches fix the build errors.
- https://lore.kernel.org/cip-dev/1732007374-15710-1-git-send-email-nobuhiro1.iwamatsu@toshiba.co.jp/
- https://lore.kernel.org/cip-dev/1732007030-15207-1-git-send-email-nobuhiro1.iwamatsu@toshiba.co.jp/
Quoted 3 lines
CU
Uli
Best regards,
Nobuhiro
Quoted 7 lines · CET Nobuhiro Iwamatsu via lists.cip-project.org
Thanks for your work! I reviewed these commits. There doesn't seem to be any problem without Pavel's comment. BTW, could you also consider applying the following patches? These two patches fix the build errors.
- https://lore.kernel.org/cip-dev/1732007374-15710-1-git-send-email-nobuhiro1.iwamatsu@toshiba.co.jp/
- https://lore.kernel.org/cip-dev/1732007030-15207-1-git-send-email-nobuhiro1.iwamatsu@toshiba.co.jp/
Picked those up already after the RC; sorry for not mentioning that earlier.
CU
Uli