Skip to contentSkip to conversation

2.5.68-bk10 blkmtd.c:219: warning: implicit declaration of function `alloc_kiovec'

DISCUSSION Grzegorz Jaskiewicz 3 participants 6 messages Apr 30, 2003 – May 1, 2003

lore
Share & tools
lore
#0 lore raw

Well, "burned" on ieee1394 i will not try to patch it my self :) Anyway, i can live without those drivers :)
make -f scripts/Makefile.build obj=drivers/mtd/devices
gcc -Wp,-MD,drivers/mtd/devices/.blkmtd.o.d -D__KERNEL__ -Iinclude
-Wall -Wstrict-prototypes -Wno-trigraphs -O2 -fno-strict-aliasing -fno-common -pipe -mpreferred-stack-boundary=2 -march=i686 -falign-functions=0 -falign-jumps=0 -falign-loops=0 -Iinclude/asm-i386/mach-default -fomit-frame-pointer -nostdinc
-iwithprefix include -DMODULE -DKBUILD_BASENAME=blkmtd
-DKBUILD_MODNAME=blkmtd -c -o drivers/mtd/devices/.tmp_blkmtd.o drivers/mtd/devices/blkmtd.c drivers/mtd/devices/blkmtd.c:52:25: linux/iobuf.h: No such file or directory
drivers/mtd/devices/blkmtd.c: In function `blkmtd_readpage':
drivers/mtd/devices/blkmtd.c:219: warning: implicit declaration of function `alloc_kiovec'
drivers/mtd/devices/blkmtd.c:236: dereferencing pointer to incomplete type
drivers/mtd/devices/blkmtd.c:239: dereferencing pointer to incomplete type
drivers/mtd/devices/blkmtd.c:240: dereferencing pointer to incomplete type
drivers/mtd/devices/blkmtd.c:241: dereferencing pointer to incomplete type
drivers/mtd/devices/blkmtd.c:242: dereferencing pointer to incomplete type
drivers/mtd/devices/blkmtd.c:243: dereferencing pointer to incomplete type
drivers/mtd/devices/blkmtd.c:265: warning: implicit declaration of function `brw_kiovec'
drivers/mtd/devices/blkmtd.c:267: dereferencing pointer to incomplete type
drivers/mtd/devices/blkmtd.c:268: warning: implicit declaration of function `free_kiovec'
drivers/mtd/devices/blkmtd.c:169: warning: unused variable b' drivers/mtd/devices/blkmtd.c: In function write_queue_task':
drivers/mtd/devices/blkmtd.c:323: dereferencing pointer to incomplete type
drivers/mtd/devices/blkmtd.c:351: `KIO_MAX_SECTORS' undeclared (first use in this function)
drivers/mtd/devices/blkmtd.c:351: (Each undeclared identifier is reported only once
drivers/mtd/devices/blkmtd.c:351: for each function it appears in.) drivers/mtd/devices/blkmtd.c:369: dereferencing pointer to incomplete type
drivers/mtd/devices/blkmtd.c:370: dereferencing pointer to incomplete type
drivers/mtd/devices/blkmtd.c:382: dereferencing pointer to incomplete type
drivers/mtd/devices/blkmtd.c:384: dereferencing pointer to incomplete type
drivers/mtd/devices/blkmtd.c:392: dereferencing pointer to incomplete type
drivers/mtd/devices/blkmtd.c:393: dereferencing pointer to incomplete type
drivers/mtd/devices/blkmtd.c:407: dereferencing pointer to incomplete type
drivers/mtd/devices/blkmtd.c: In function `blkmtd_erase':
drivers/mtd/devices/blkmtd.c:527: warning: unused variable b' drivers/mtd/devices/blkmtd.c: In function blkmtd_read':
drivers/mtd/devices/blkmtd.c:640: warning: unused variable b' drivers/mtd/devices/blkmtd.c: In function blkmtd_write':
drivers/mtd/devices/blkmtd.c:713: syntax error before "e3" drivers/mtd/devices/blkmtd.c:712: warning: unused variable b' drivers/mtd/devices/blkmtd.c: In function init_blkmtd':
drivers/mtd/devices/blkmtd.c:1060: warning: unused variable `b' make[3]: *** [drivers/mtd/devices/blkmtd.o] Error 1 make[2]: *** [drivers/mtd/devices] Error 2
make[1]: *** [drivers/mtd] Error 2
make: *** [drivers] Error 2

Signature · 2 lines
Grzegorz Jaskiewicz <[email protected]>
K4 labs
#1 lore raw
Quoted 6 lines · Grzegorz Jaskiewicz

Well, "burned" on ieee1394 i will not try to patch it my self :) Anyway, i can live without those drivers :)

drivers/mtd/devices/blkmtd.c:52:25: linux/iobuf.h: No such file or directory

I've tried to investigate this. What happend to iobuf.{ch} ? I guess bit more changes are required to make it running before 2.6 :)

Btw, authors email in head of blkmtd.c is bad.

Fanny thing, after removing this include there is declaration :

/* readpage() - reads one page from the block device */
static int blkmtd_readpage(mtd_raw_dev_data_t *rawdevice, struct page *page) {
int err;
int sectornr, sectors, i;

  struct kiobuf *iobuf;
	^^^^^^^

unsigned long *blocks;

Fast fgrep in kernel sources gives me no answer about this structure declaration.

any help guys ?

Signature · 2 lines
Grzegorz Jaskiewicz <[email protected]>
K4 labs
#2 lore raw
Quoted 7 lines · Grzegorz Jaskiewicz
  struct kiobuf *iobuf;
	^^^^^^^

unsigned long *blocks;

Fast fgrep in kernel sources gives me no answer about this structure declaration.

blkmtd died when kiobufs were removed. The maintainer said "oh well, OK, I need to rewrite it anyway" but that obviously has not yet happened.

#3 lore raw
Quoted 3 lines · Andrew Morton

blkmtd died when kiobufs were removed. The maintainer said "oh well, OK, I need to rewrite it anyway" but that obviously has not yet happened.

:/

So why we still have this in kernel ?
I don't have any of those devices, so i am not even able to correct this. If i will have, i will do so (at least try).

I hope that is the only case, when somebody leaves project this way.

Signature · 2 lines
Grzegorz Jaskiewicz <[email protected]>
K4 labs
#4 lore raw
Quoted 10 lines · Grzegorz Jaskiewicz
Quoted 3 lines · Andrew Morton

blkmtd died when kiobufs were removed. The maintainer said "oh well, OK, I need to rewrite it anyway" but that obviously has not yet happened.

:/

So why we still have this in kernel ?

Waiting for the maintainer to fix it up.

Quoted 2 lines

I don't have any of those devices, so i am not even able to correct this. If i will have, i will do so (at least try).

All it needs is a disk drive:

* blkmtd.c - use a block device as a fake MTD

#5 lore raw

Re: 2.5.68-bk10 blkmtd.c:219: warning: implicit declaration offunction `alloc_kiovec'

In reply to Andrew Morton
Quoted 11 lines · Andrew Morton
Quoted 7 lines · Grzegorz Jaskiewicz
  struct kiobuf *iobuf;
	^^^^^^^

unsigned long *blocks;

Fast fgrep in kernel sources gives me no answer about this structure declaration.

blkmtd died when kiobufs were removed. The maintainer said "oh well, OK, I need to rewrite it anyway" but that obviously has not yet happened.

There's a new blkmtd in the MTD CVS.

David:
What are your current plans regarding merging the MTD CVS into 2.5?

cu
Adrian

[1] http://www.linux-mtd.infradead.org/

Signature · 4 lines
       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed