2.5.69 drivers/bluetooth/hci_usb.c USB_ZERO_PACKET

drivers/bluetooth/hci_usb.c :
USB_ZERO_PACKET definition is missing if CONFIG_BT_SUB_ZERO_PACKET is not defined.

#define USB_ZERO_PACKET 0

in this file helps, but i guess it is not the best and fully correct solution :)

Cheers!

Grzegorz Jaskiewicz <[email protected]>
K4 labs

Oh, one small question. I am wondering, shouldn't this define be done in some USB header file ?
If so, please give me some hints i will correct it my self :)

Grzegorz Jaskiewicz <[email protected]>
K4 labs

Grzegorz Jaskiewicz <[email protected]> :
[...]

If I remember M. KH's message of last week, it should be something like the following patch. Now I can't remember who he told it should be sent to :o)

Typo: s/USB_ZERO_PACKET/URB_ZERO_PACKET/

 drivers/bluetooth/hci_usb.c |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

diff -puN drivers/bluetooth/hci_usb.c~typo-usb_zero_packet drivers/bluetooth/hci_usb.c
@@ -64,8 +64,8 @@
 #endif
 
 #ifndef CONFIG_BT_USB_ZERO_PACKET
-#undef  USB_ZERO_PACKET
-#define USB_ZERO_PACKET 0
+#undef  URB_ZERO_PACKET
+#define URB_ZERO_PACKET 0
 #endif
 
 static struct usb_driver hci_usb_driver; 

@@ -458,7 +458,7 @@ static inline int hci_usb_send_bulk(stru
 	pipe = usb_sndbulkpipe(husb->udev, husb->bulk_out_ep->desc.bEndpointAddress);
 	usb_fill_bulk_urb(urb, husb->udev, pipe, skb->data, skb->len, 
 			hci_usb_tx_complete, husb);
-	urb->transfer_flags = USB_ZERO_PACKET;
+	urb->transfer_flags = URB_ZERO_PACKET;
 
 	BT_DBG("%s skb %p len %d", husb->hdev.name, skb, skb->len);
 

_

indeed. I can see it now somewhere on a list :-]

Grzegorz Jaskiewicz <[email protected]>
K4 labs