Skip to contentSkip to conversation

Fix warning with ndelay

PATCH In review Benjamin Herrenschmidt 2 participants 3 messages May 23, 2003

lore
Share & tools
lore
author
#1 lore raw

Re: [PATCH] PPC32 Fix warning with ndelay (with patch !)

OOOps, here's the real one...

This patch fixes a warning with recent gcc's when using the new ndelay() function, by properly defining a large constant as unsigned

===== include/asm-ppc/delay.h 1.5 vs edited =====

include/asm-ppc/delay.h +2 -2
@@ -30,8 +30,8 @@
  * (which corresponds to ~3800 bogomips at HZ = 100).
  *  -- paulus
  */
-#define __MAX_UDELAY	(226050910/HZ)	/* maximum udelay argument */
-#define __MAX_NDELAY	(4294967295/HZ)	/* maximum ndelay argument */
+#define __MAX_UDELAY	(226050910UL/HZ)	/* maximum udelay argument */
+#define __MAX_NDELAY	(4294967295UL/HZ)	/* maximum ndelay argument */
 
 extern __inline__ void __udelay(unsigned int x)
 {
#2 lore raw
In reply to Benjamin Herrenschmidt

Hi Benjamin.

Did you forget to enclose the patch?

Best wishes from Riley.
---
* Nothing as pretty as a smile, nothing as ugly as a frown.

Quoted 25 lines

-----Original Message-----
From: [email protected] [mailto:[email protected]]On Behalf Of Benjamin Herrenschmidt
Sent: Friday, May 23, 2003 9:38 AM
To: Marcelo Tosatti
Cc: Paul Mackerras; linux-kernel mailing list
Subject: [PATCH] Fix warning with ndelay

Signature · 12 lines
Benjamin Herrenschmidt <[email protected]>
-
To unsubscribe from this list: send the line "unsubscribe 
linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---
Incoming mail is certified Virus Free.
Checked by AVG anti-virus system (http://www.grisoft.com).
Version: 6.0.483 / Virus Database: 279 - Release Date: 19-May-2003

---
Outgoing mail is certified Virus Free.
Checked by AVG anti-virus system (http://www.grisoft.com).
Version: 6.0.483 / Virus Database: 279 - Release Date: 19-May-2003