Skip to contentSkip to conversation

move sg_dma_ macros out of asm-i386/pci.h

PATCH New James Bottomley 1 participant 1 message Jun 30, 2003

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 move sg_dma_ macros out of asm-i386/pci.h

These macros belong in asm-i386/scatterlist.h instead.

As the headers are disentangled this has shown up as a problem with my MCA SCSI drivers since they no-longer include asm/pci.h in any form but need to traverse the scatterlist.

James

===== include/asm-i386/pci.h 1.22 vs edited =====

include/asm-i386/pci.h +0 -8
@@ -82,14 +82,6 @@
 	flush_write_buffers();
 }
 
-/* These macros should be used after a pci_map_sg call has been done
- * to get bus addresses of each of the SG entries and their lengths.
- * You should only work with the number of sg entries pci_map_sg
- * returns.
- */
-#define sg_dma_address(sg)	((sg)->dma_address)
-#define sg_dma_len(sg)		((sg)->length)
-
 #define HAVE_PCI_MMAP
 extern int pci_mmap_page_range(struct pci_dev *dev, struct vm_area_struct *vma,
 			       enum pci_mmap_state mmap_state, int write_combine);

===== include/asm-i386/scatterlist.h 1.3 vs edited =====

include/asm-i386/scatterlist.h +8 -0
@@ -8,6 +8,14 @@
     unsigned int	length;
 };
 
+/* These macros should be used after a pci_map_sg call has been done
+ * to get bus addresses of each of the SG entries and their lengths.
+ * You should only work with the number of sg entries pci_map_sg
+ * returns.
+ */
+#define sg_dma_address(sg)	((sg)->dma_address)
+#define sg_dma_len(sg)		((sg)->length)
+
 #define ISA_DMA_THRESHOLD (0x00ffffff)
 
 #endif /* !(_I386_SCATTERLIST_H) */