Flash IDs for STM M28W320CB
PATCH 1/1 Flash IDs for STM M28W320CB
A trivial patch for include/flash.h
Changelog:
Patch by Andreas Oberritter, 19 July 03:
- Add IDs for STM M28W320CB 32MBit flash type
-------------- next part --------------
include/flash.h +2 -0
@@ -182,6 +182,7 @@#define STM_ID_29W320DT 0x22CA22CA/* M29W320DT ID (32 M, top boot sector) */ #define STM_ID_29W320DB 0x22CB22CB/* M29W320DB ID (32 M, bottom boot sect) */ #define STM_ID_29W040B 0x00E300E3/* M29W040B ID (4M = 512K x 8) */ +#define STM_ID_28W320CB 0x88BB88BB/* M28W320CB ID (4M = 256K x 16, bottom)*/ #define INTEL_ID_28F016S 0x66a066a0/* 28F016S[VS] ID (16M = 512k x 16) */ #define INTEL_ID_28F800B3T 0x88928892/* 8M = 512K x 16 top boot sector */
@@ -266,6 +267,7 @@#define FLASH_STM800AB 0x0051/* STM M29WF800AB ( 8M = 512K x 16 ) */ #define FLASH_STMW320DT 0x0052/* STM M29W320DT (32 M, top boot sector) */ #define FLASH_STMW320DB 0x0053/* STM M29W320DB (32 M, bottom boot sect)*/ +#define FLASH_STM320CB 0x005D/* STM M28W320CB (4M = 256K x 16, bottom)*/ #define FLASH_STM320DB 0x00CB/* STM M29W320DB (4M = 64K x 64, bottom)*/ #define FLASH_STM800DT 0x00D7/* STM M29W800DT (1M = 64K x 16, top) */ #define FLASH_STM800DB 0x005B/* STM M29W800DB (1M = 64K x 16, bottom)*/
PATCH 1/1 Flash IDs for STM M28W320CB
Dear Andreas,
Quoted 2 lines · in message <1058581190.943.22.camel@localhost> you wrote:
A trivial patch for
include/flash.h
...
Quoted 1 line
+#define
STM_ID_28W320CB0x88BB88BB/* M28W320CB ID (4M = 256K x 16, bottom)*/
...
Quoted 1 line
+#define
FLASH_STM320CB0x005D/* STM M28W320CB (4M = 256K x 16, bottom)*/
Why should we add these definitions? No code in U-Boot uses these variables.
Patch rejected.
Best regards,
Wolfgang Denk
Signature · 4 lines
Software Engineering: Embedded and Realtime Systems, Embedded Linux Phone: (+49)-8142-4596-87 Fax: (+49)-8142-4596-88 Email: wd at denx.de Don't put off for tomorrow what you can do today, because if you enjoy it today you can do it again tomorrow.
PATCH 1/1 Flash IDs for STM M28W320CB
Hi Wolfgang,
Quoted 6 lines · Wolfgang Denk
Quoted 1 line
+#define
STM_ID_28W320CB0x88BB88BB/* M28W320CB ID (4M = 256K x 16, bottom)*/...
Quoted 1 line
+#define
FLASH_STM320CB0x005D/* STM M28W320CB (4M = 256K x 16, bottom)*/Why should we add these definitions? No code in U-Boot uses these variables.
It is used in the flash code for our board (see link below). I will clean up the code for it and hope to get it merged into your cvs tree soon (without the framebuffer, mpeg decoder and scart stuff). My intention was to submit the trivial patches first before the board code to keep the board patch smaller. However, I will review the patches and try again with a complete patch set.
http://cvs.tuxbox.org/cgi-bin/viewcvs.cgi/tuxbox/boot/u-boot/board/dbox2/flash.c?rev=HEAD
Regards,
Andreas