Skip to contentSkip to conversation

ips: remove arch limitations

PATCH In review David Jeffery 2 participants 2 messages Aug 28, 2003

Subsystems (3)
SCSI IBM ServeRAID RAID driver Ips SCSI RAID driver
lore
Share & tools
lore

David Jeffery

author
#0 lore raw

PATCH 1/1 ips: remove arch limitations

This patch removes the X86 arch limitation in drivers/scsi/Kconfig, downgrades the #error check for x86/x86_64/ia64 to a #warning, and updates an old email address in the help.

It also fixes up a two places in the driver which have 8 spaces instead of a tab for indention.

David Jeffery

drivers/scsi/Kconfig +2 -2
diff -urN linux-2.6.0-test4_p0/drivers/scsi/Kconfig linux-2.6.0-test4_p1/drivers/scsi/Kconfig
@@ -726,13 +726,13 @@
 
 config SCSI_IPS
 	tristate "IBM ServeRAID support"
-	depends on X86 && PCI && SCSI
+	depends on PCI && SCSI
 	---help---
 	  This is support for the IBM ServeRAID hardware RAID controllers.
 	  See <http://www.developer.ibm.com/welcome/netfinity/serveraid.html>
 	  for more information.  If this driver does not work correctly
 	  without modification please contact the author by email at
-	  [email protected].
+	  [email protected].
 
 	  You can build this driver as a module ( = code which can be
 	  inserted in and removed from the running kernel whenever you want),
drivers/scsi/ips.c +5 -5
diff -urN linux-2.6.0-test4_p0/drivers/scsi/ips.c linux-2.6.0-test4_p1/drivers/scsi/ips.c
@@ -199,7 +199,7 @@
 #define IPS_VERSION_LOW         ".90-BETA"
 
 #if !defined(__i386__) && !defined(__ia64__) && !defined(__x86_64__)
-#error "This driver has only been tested on the x86/ia64/x86_64 platforms"
+#warning "This driver has only been tested on the x86/ia64/x86_64 platforms"
 #endif
 
 #if LINUX_VERSION_CODE <= KERNEL_VERSION(2,5,0)

@@ -284,9 +284,9 @@
 /* This table describes all ServeRAID Adapters */
 static struct  pci_device_id  ips_pci_table[] = {
 	{ 0x1014, 0x002E, PCI_ANY_ID, PCI_ANY_ID, 0, 0 },
-        { 0x1014, 0x01BD, PCI_ANY_ID, PCI_ANY_ID, 0, 0 },
-        { 0x9005, 0x0250, PCI_ANY_ID, PCI_ANY_ID, 0, 0 },
-        { 0, }
+	{ 0x1014, 0x01BD, PCI_ANY_ID, PCI_ANY_ID, 0, 0 },
+	{ 0x9005, 0x0250, PCI_ANY_ID, PCI_ANY_ID, 0, 0 },
+	{ 0, }
 };
 
 MODULE_DEVICE_TABLE( pci, ips_pci_table );

@@ -300,7 +300,7 @@
 	.name		= ips_hot_plug_name,
 	.id_table	= ips_pci_table,
 	.probe		= ips_insert_device,
-        .remove		= __devexit_p(ips_remove_device),
+	.remove		= __devexit_p(ips_remove_device),
 };
#1 lore raw
Quoted 6 lines · David Jeffery

This patch removes the X86 arch limitation in drivers/scsi/Kconfig, downgrades the #error check for x86/x86_64/ia64 to a #warning, and updates an old email address in the help.

It also fixes up a two places in the driver which have 8 spaces instead of a tab for indention.

Looks good, thanks!

Jeff