SCSI sync

BKPATCH Linus Torvalds 3 participants 3 messages Sep 27, 2003 1 message not in the archive SCSI

lore

Share & tools

lore

A message that is not in the archive (sent off-list or not yet received): 1064629718.1861.12.camel@mulgrave

Linus Torvalds

author

2003-09-27 18:13 UTC #1 lore raw

Hmm.. With "make allyesconfig" I get

drivers/scsi/g_NCR5380.c: In function `generic_NCR5380_proc_info':
drivers/scsi/g_NCR5380.c:863: `phases' undeclared (first use in this function) drivers/scsi/g_NCR5380.c:863: (Each undeclared identifier is reported only once drivers/scsi/g_NCR5380.c:863: for each function it appears in.)

what's this? It's the only place in the whole source file that has "phases".

Linus

James Bottomley

2003-09-27 21:20 UTC #2 lore raw

Quoted 2 lines · Linus Torvalds

what's this? It's the only place in the whole source file that has "phases".

OK, after a bit of a paperchase, this is the problem:

hangeSet 1.1217.10.7 2003/09/12 09:52:45 [email protected]
[PATCH] NCR5380.c warning

NCR5380: `phases' is used inside the #ifdef NDEBUG only, so move its
definition
inside as well.

It wasn't realised that NCR5380.c is #included into g_NCR5380.c and provided the phases[] array for that as well.

James

Geert Uytterhoeven

2003-09-27 21:29 UTC #3 lore raw

Quoted 9 lines · James Bottomley

Quoted 2 lines · Linus Torvalds
what's this? It's the only place in the whole source file that has "phases".
OK, after a bit of a paperchase, this is the problem:
hangeSet 1.1217.10.7 2003/09/12 09:52:45 [email protected]
[PATCH] NCR5380.c warning

Quoted 6 lines

NCR5380: `phases' is used inside the #ifdef NDEBUG only, so move its
definition
inside as well.
It wasn't realised that NCR5380.c is #included into g_NCR5380.c and provided the phases[] array for that as well.

Oops, sorry, I didn't notice that g_NCR5380.c is the only NCR5380 driver that uses phases[] beyond debugging.

I think the NCR5380 core and drivers need some clean up. Including other C sources and #define'ing all the NCR5380_*() routines isn't exacly the cleanest way to handle abstraction...

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds