Skip to contentSkip to conversation

Using in_8 and out_8 without module optimization

DISCUSSION Seb James 4 participants 4 messages Oct 21, 2003 – Oct 22, 2003

lore
Share & tools
lore

Seb James

author
#0 lore raw

Hello,

I have a kernel module that I wish to insmod into a linux kernel running on a powerpc chip (mpc823).

It uses an inline function declared and defined in asm-ppc/io.h: out_8.

I #include io.h in my code, and call the function out_8. The code compiles fine. The module insmods fine as long as I called gcc with -O for some optimization when compiling.

I need to run the module without optimization as I really need a section of the code to run exactly as I've coded it, but when I compile without the -O, insmod fails to insert the module, complaining:

driver.o: unresolved symbol out_8

Something to do with the fact that -O inlines quite a lot of the functions in my module, but I don't understand any further than this. Can anyone suggest a way I can use out_8 without optimizing my module?

best regards,

Seb James.

** Sent via the linuxppc-dev mail list. See http://lists.linuxppc.org/

#1 lore raw

Hi Seb,

to get inline's expanded you need at least "-O" optimization. To ensure that the asm-code is executed in sequence with your C-code use:

-fno-schedule-insns -fno-schedule-insns2

Hope that's what you are looking for.

Ciao, Wolfgang.

Quoted 25 lines

-- Original Message --
Subject: Using in_8 and out_8 without module optimization
From: Seb James <[email protected]>
To: [email protected]
Date: 21 Oct 2003 14:25:24 +0100

Hello,

I have a kernel module that I wish to insmod into a linux kernel running on a powerpc chip (mpc823).

It uses an inline function declared and defined in asm-ppc/io.h: out_8.

I #include io.h in my code, and call the function out_8. The code compiles fine. The module insmods fine as long as I called gcc with -O for some optimization when compiling.

I need to run the module without optimization as I really need a section of the code to run exactly as I've coded it, but when I compile without the -O, insmod fails to insert the module, complaining:

driver.o: unresolved symbol out_8

Quoted 10 lines

Something to do with the fact that -O inlines quite a lot of the functions in my module, but I don't understand any further than this. Can anyone suggest a way I can use out_8 without optimizing my module?

best regards,

Seb James.

** Sent via the linuxppc-dev mail list. See http://lists.linuxppc.org/

#2 lore raw
Quoted 5 lines · Wolfgang Grandegger

To ensure that the asm-code is executed in sequence with your C-code use:

-fno-schedule-insns -fno-schedule-insns2

Some other optimizations might still rearrange code, so consider -fno-strength-reduce and -fno-move-all-moveables and possibly a few other switches. Just compile with -S and see if the assembly code looks right.

I think there is also a switch to force inline functions to be instantiated, could be -fno-inline or -fforce-no-inline, but the former solution is likely a lot better.

Holger

** Sent via the linuxppc-dev mail list. See http://lists.linuxppc.org/

#3 lore raw
In reply to Seb James
Quoted 3 lines · Seb James

I need to run the module without optimization as I really need a section of the code to run exactly as I've coded it, but when I compile without

re-write that section in assembly.

Note that even if the compiler doesn't reorder insn's or memory load/store's, the CPU might still excecute out-of-order, and/or the memory controller (if any) might store/load out of order. If you need guarenteed order of execution, you need to use memory/io barriers, e.g. eieio, sync; if you are seeing cacheing of i/o loads/stores, you are probably not using 'volatile' (or not using it correctly).

Quoted 11 lines · Holger Bettag
Quoted 5 lines · Wolfgang Grandegger

To ensure that the asm-code is executed in sequence with your C-code use:

-fno-schedule-insns -fno-schedule-insns2

Some other optimizations might still rearrange code, so consider -fno-strength-reduce and -fno-move-all-moveables and possibly a few other switches. Just compile with -S and see if the assembly code looks right.

If a device driver breaks because of compiler optimizations, the answer is to fix the device driver, not to disable optimization. I'm guessing that the driver isn't using eieio in all the right places. (and/or volatile).

--linas

** Sent via the linuxppc-dev mail list. See http://lists.linuxppc.org/