Skip to contentSkip to conversation

superfluous assignement in ide_diag_taskfile()

PATCH New Bernadette SING 1 participant 1 message Dec 23, 2003 Kbuild

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 superfluous assignement in ide_diag_taskfile()

Hi,

Quoted 1 line

From ide_diag_taskfile()

        ide_init_drive_taskfile(&rq);
        rq.flags = REQ_DRIVE_TASKFILE;
        rq.buffer = buf;

but in ide_init_drive_taskfile() we've got:

	void ide_init_drive_taskfile (struct request *rq)
	{
	        memset(rq, 0, sizeof(*rq));
	        rq->flags = REQ_DRIVE_TASKFILE;
	}	

The REQ_DRIVE_TASKFILE assignement in ide_diag_taskfile() looks superfluous.
Patch attached.

Signature · 1 line
Frederik DEWEERDT
drivers/ide/ide-taskfile.c renamed from usr/src/linux-2.6.0/drivers/ide/ide-taskfile.c +0 -1
@@ -1372,7 +1372,6 @@
 	struct request rq;
 
 	ide_init_drive_taskfile(&rq);
-	rq.flags = REQ_DRIVE_TASKFILE;
 	rq.buffer = buf;
 
 	/*