Problem with CONFIG_SYSCTL disabled
Subsystems (2)
Hi Folks,
with the latest 2.6.1-bk5 I got the following error:
In file included from drivers/net/net_init.c:53:
include/net/neighbour.h:216: error: parse error before "proc_handler" include/net/neighbour.h:216: warning: function declaration isn't a prototype
Looking for the reason it seems that I have to enable CONFIG_SYSCTL to make this compile. The following patch introduces this problem:
[email protected], 2004-01-15 00:58:20-08:00, [email protected] [IPV6]: Implement MIB:ipv6InterfaceTable
Regards
Marcel
In article <1074519043.6070.93.camel@pegasus> (at Mon, 19 Jan 2004 14:30:43 +0100), Marcel Holtmann <[email protected]> says:
Quoted 3 lines
In file included from
drivers/net/net_init.c:53:
include/net/neighbour.h:216: error: parse error before "proc_handler"include/net/neighbour.h:216: warning: function declaration isn't a prototype
===== include/net/neighbour.h 1.5 vs edited =====
include/net/neighbour.h +0 -2
@@ -47,9 +47,7 @@#include <linux/skbuff.h> #include <linux/err.h> -#ifdef CONFIG_SYSCTL #include <linux/sysctl.h> -#endif #define NUD_IN_TIMER (NUD_INCOMPLETE|NUD_DELAY|NUD_PROBE)#define NUD_VALID (NUD_PERMANENT|NUD_NOARP|NUD_REACHABLE|NUD_PROBE|NUD_STALE|NUD_DELAY)
Signature · 2 lines
Hideaki YOSHIFUJI @ USAGI Project <[email protected]> GPG FP: 9022 65EB 1ECF 3AD1 0BDF 80D8 4807 F894 E062 0EEA
Hi,
Quoted 8 lines
Quoted 3 lines
In file included from
drivers/net/net_init.c:53:
include/net/neighbour.h:216: error: parse error before "proc_handler"include/net/neighbour.h:216: warning: function declaration isn't a prototype=====
include/net/neighbour.h1.5 vs edited =====
include/net/neighbour.h line 53
Quoted 9 lines
include/net/neighbour.h +0
-2@@ -47,9 +47,7 @@#include <linux/skbuff.h> #include <linux/err.h> -#ifdef CONFIG_SYSCTL #include <linux/sysctl.h> -#endif #define NUD_IN_TIMER (NUD_INCOMPLETE|NUD_DELAY|NUD_PROBE)#define NUD_VALID (NUD_PERMANENT|NUD_NOARP|NUD_REACHABLE|NUD_PROBE|NUD_STALE|NUD_DELAY)
so it is not needed to wrap the inclusion of linux/sysctl.h around #ifdef's, but why is it done so many times?
net/core/neighbour.c net/ipv4/devinet.c net/ipv4/arp.c net/ipv4/route.c net/ipv4/netfilter/ip_conntrack_standalone.c net/ipv6/route.c net/ipv6/addrconf.c net/ipv6/ndisc.c net/ipv6/icmp.c net/appletalk/sysctl_net_atalk.c net/bridge/br_netfilter.c
Regards
Marcel
In article <1074521369.6070.99.camel@pegasus> (at Mon, 19 Jan 2004 15:09:29 +0100), Marcel Holtmann <[email protected]> says:
Quoted 14 lines
so it is not needed to wrap the inclusion of
linux/sysctl.haround #ifdef's, but why is it done so many times?net/core/neighbour.c net/ipv4/devinet.c net/ipv4/arp.c net/ipv4/route.c net/ipv4/netfilter/ip_conntrack_standalone.c net/ipv6/route.c net/ipv6/addrconf.c net/ipv6/ndisc.c net/ipv6/icmp.c net/appletalk/sysctl_net_atalk.c net/bridge/br_netfilter.c
Compilation time?
If one does not require linux/sysctl.h without CONFIG_SYSCTL, you don't need to include it.
--yoshfuji
Em Seg, 2004-01-19 às 12:21, YOSHIFUJI Hideaki / 吉藤英明 escreveu:
Quoted 17 lines
In article <1074521369.6070.99.camel@pegasus> (at Mon, 19 Jan 2004 15:09:29 +0100), Marcel Holtmann <[email protected]> says:
Quoted 14 lines
so it is not needed to wrap the inclusion of
linux/sysctl.haround #ifdef's, but why is it done so many times?net/core/neighbour.c net/ipv4/devinet.c net/ipv4/arp.c net/ipv4/route.c net/ipv4/netfilter/ip_conntrack_standalone.c net/ipv6/route.c net/ipv6/addrconf.c net/ipv6/ndisc.c net/ipv6/icmp.c net/appletalk/sysctl_net_atalk.c net/bridge/br_netfilter.c
Quoted 1 line
Compilation time?
I fixed the net/bridge/br_netfilter.c, and sent the patch to Andrew
(and him fowarded to D. Miller, I though that was -mm problem).
Quoted 2 lines
If one does not require
linux/sysctl.hwithoutCONFIG_SYSCTL, you don't need to include it.
I take a quick look, there are other places to fix. Should it be a
janitor task ?
Signature · 9 lines
Luiz Fernando N. Capitulino <[email protected]> <http://www.telecentros.sp.gov.br> _______________________________________________ Kernel-janitors mailing list [email protected] http://lists.osdl.org/mailman/listinfo/kernel-janitors
Quoted 5 lines · On Mon, 19 Jan 2004 13:06:12 -0200 Luiz Fernando Capitulino…
Quoted 2 lines
If one does not require
linux/sysctl.hwithoutCONFIG_SYSCTL, you don't need to include it.I take a quick look, there are other places to fix. Should it be a
janitor task ?
Yes, it's just ugly to have these ifdefs in *.c files _if_ they can be avoided.
Meanwhile I've applied the neighbour.h fix from Yoshfuji-san.
_______________________________________________
Kernel-janitors mailing list [email protected]
http://lists.osdl.org/mailman/listinfo/kernel-janitors