Skip to contentSkip to conversation

PATCH: Aureal vortex alsa-kernel.

DISCUSSION Manuel Jander 2 participants 3 messages Jan 25, 2004 – Jan 26, 2004

lore
Share & tools
lore
#0 lore raw

Hi,

To the ALSA tree maintainers:

I have uploaded a patch which moves the current Aureal driver into the alsa-kernel/ directory. Please apply it, because many people are waiting for it since a long time, and the driver is working stable. I really need this to be done, please.

Patch location:
http://galadriel.mat.utfsm.cl/~mjander/aureal/alsa/patch.gz
(about 100KiB)

Best Regards

Manuel Jander

-------------------------------------------------------
The SF.Net email is sponsored by EclipseCon 2004 Premiere Conference on Open Tools Development and Integration See the breadth of Eclipse activity. February 3-5 in Anaheim, CA.
http://www.eclipsecon.org/osdn

#1 lore raw

Hi Manuel,

At Sat, 24 Jan 2004 20:19:36 -0400,

Quoted 5 lines · Manuel Jander

Hi,

To the ALSA tree maintainers:

Quoted 8 lines

I have uploaded a patch which moves the current Aureal driver into the alsa-kernel/ directory. Please apply it, because many people are waiting for it since a long time, and the driver is working stable. I really need this to be done, please.

Patch location:
http://galadriel.mat.utfsm.cl/~mjander/aureal/alsa/patch.gz
(about 100KiB)

oh i wanted to ask you today the exactly same thing, but you must have seen it via a tarot card :)

the patch looks nice, but please clean up the codes a bit more before merging to alsa-kernel, namely,

- use the correct tab width (8) and indentation. e.g. the open brace are usually put in the next line.

- remove the unnecessary (and skeptical) codes such as disasembling or c++ codes from somewhere else. only your own codes, please.

- put GPL notice to each file.
ok, we don't need it for au8810.c & co...

- add EXPORT_NO_SYMBOLS; to the main file of alsa-driver (not alsa-kernel). apparently we have forgotten that.

thanks,

Takashi

-------------------------------------------------------
The SF.Net email is sponsored by EclipseCon 2004 Premiere Conference on Open Tools Development and Integration See the breadth of Eclipse activity. February 3-5 in Anaheim, CA.
http://www.eclipsecon.org/osdn

#2 lore raw

At Mon, 26 Jan 2004 11:32:59 +0100,

Quoted 28 lines · I wrote:

Hi Manuel,

At Sat, 24 Jan 2004 20:19:36 -0400,

Quoted 5 lines · Manuel Jander

Hi,

To the ALSA tree maintainers:

Quoted 8 lines

I have uploaded a patch which moves the current Aureal driver into the alsa-kernel/ directory. Please apply it, because many people are waiting for it since a long time, and the driver is working stable. I really need this to be done, please.

Patch location:
http://galadriel.mat.utfsm.cl/~mjander/aureal/alsa/patch.gz
(about 100KiB)

oh i wanted to ask you today the exactly same thing, but you must have seen it via a tarot card :)

the patch looks nice, but please clean up the codes a bit more before merging to alsa-kernel, namely,

- use the correct tab width (8) and indentation. e.g. the open brace are usually put in the next line.

Quoted 8 lines

- remove the unnecessary (and skeptical) codes such as disasembling or c++ codes from somewhere else. only your own codes, please.

- put GPL notice to each file.
ok, we don't need it for au8810.c & co...

- add EXPORT_NO_SYMBOLS; to the main file of alsa-driver (not alsa-kernel). apparently we have forgotten that.

also, give the patch for ALSA-Configuration.txt, too.

Takashi

-------------------------------------------------------
The SF.Net email is sponsored by EclipseCon 2004 Premiere Conference on Open Tools Development and Integration See the breadth of Eclipse activity. February 3-5 in Anaheim, CA.
http://www.eclipsecon.org/osdn