Skip to contentSkip to conversation

drivers/ieee1394/sbp2.c:734: error: `host' undeclared (first use in this function) 2.6.3-bk3

DISCUSSION Bob Gill 3 participants 3 messages Feb 21, 2004 – Feb 22, 2004

lore
Share & tools
lore

Bob Gill

author
#0 lore raw

Hi. The whole error message is (when building 2.6.3-bk3):
drivers/ieee1394/sbp2.c: In function `sbp2_alloc_device':
drivers/ieee1394/sbp2.c:734: error: `host' undeclared (first use in this function)
drivers/ieee1394/sbp2.c:734: error: (Each undeclared identifier is reported only once
drivers/ieee1394/sbp2.c:734: error: for each function it appears in.) make[2]: *** [drivers/ieee1394/sbp2.o] Error 1
make[1]: *** [drivers/ieee1394] Error 2
make: *** [drivers] Error 2

It gives the same message when building with the source from the 1394 subversion tree. Apparently the declaration for 'host' is not where it used to be.

#ifdef CONFIG_IEEE1394_SBP2_PHYS_DMA
/* Handle data movement if physical dma is not
* enabled/supportedon host controller */
hpsb_register_addrspace(&sbp2_highlevel, host,
&sbp2_physdma_ops,

                                        0x0ULL, 0xfffffffcULL);

#endif

**--------------------------------------------------------------
highlevel.c (which isn't #included in sbp2.c) lists:

struct hl_host_info {
        struct list_head list;
        struct hpsb_host *host;
        size_t size;
        unsigned long key;
        void *data;
};

**(highlevel.h is #included in sbp2.c, highlevel.c isn't, and highlevel.h doesn't mention struct hl_host_info).
**---------------------------------------------------------------
** The above information is intended merely for recreational value
and may provide no practical information with respect to resolving the problem as I have never been accused of being a systems programmer! :)

If you need more info, please mail me as I'm not on the list. TIA,

Bob

#1 lore raw
Quoted 10 lines · Bob Gill

Hi. The whole error message is (when building 2.6.3-bk3):
drivers/ieee1394/sbp2.c: In function `sbp2_alloc_device':
drivers/ieee1394/sbp2.c:734: error: `host' undeclared (first use in this function)
drivers/ieee1394/sbp2.c:734: error: (Each undeclared identifier is reported only once
drivers/ieee1394/sbp2.c:734: error: for each function it appears in.) make[2]: *** [drivers/ieee1394/sbp2.o] Error 1
make[1]: *** [drivers/ieee1394] Error 2
make: *** [drivers] Error 2

Disable CONFIG_IEEE1394_SBP2_PHYS_DMA. I'll have this fixed next time I sync with Linus. Really, CONFIG_IEEE1394_SBP2_PHYS_DMA is for debugging only, and you shouldn't have it enabled.

Signature · 4 lines
Debian     - http://www.debian.org/
Linux 1394 - http://www.linux1394.org/
Subversion - http://subversion.tigris.org/
WatchGuard - http://www.watchguard.com/
#2 lore raw
In reply to Bob Gill
Quoted 10 lines · Bob Gill

Hi. The whole error message is (when building 2.6.3-bk3):
drivers/ieee1394/sbp2.c: In function `sbp2_alloc_device':
drivers/ieee1394/sbp2.c:734: error: `host' undeclared (first use in this function)
drivers/ieee1394/sbp2.c:734: error: (Each undeclared identifier is reported only once
drivers/ieee1394/sbp2.c:734: error: for each function it appears in.) make[2]: *** [drivers/ieee1394/sbp2.o] Error 1
make[1]: *** [drivers/ieee1394] Error 2
make: *** [drivers] Error 2

I've no hardware to test this, but does this do the right thing for you ?

Dave

drivers/ieee1394/sbp2.c renamed from drivers/ieee1394/sbp2.c~ +1 -1
@@ -727,7 +727,7 @@
 #ifdef CONFIG_IEEE1394_SBP2_PHYS_DMA
 		/* Handle data movement if physical dma is not
 		 * enabled/supportedon host controller */
-		hpsb_register_addrspace(&sbp2_highlevel, host, &sbp2_physdma_ops,
+		hpsb_register_addrspace(&sbp2_highlevel, hi->host, &sbp2_physdma_ops,
 					0x0ULL, 0xfffffffcULL);
 #endif
 	}