CONFIG_REGPARM breaks non-asmlinkage syscalls
Subsystems (4)
Hello,
with CONFIG_REGPARM=y, syscalls must be declared asmlinkage or else calling them will fail. Current gcc unfortunately does not warn about this. (I have already told one of our compiler developers.) Attached is a fix that adds a few missing declarations.
Regards,
Signature · 2 lines
Andreas Gruenbacher <[email protected]> SUSE Labs, SUSE LINUX AG
arch/ia64/ia32/sys_ia32.c +1 -1
@@ -2990,7 +2990,7 @@ sys32_timer_create(u32 clock, struct sigreturn err; } -extern long sys_fadvise64_64 (int fd,loff_t offset,loff_t len,int advice); +extern asmlinkage long sys_fadvise64_64 (int fd,loff_t offset,loff_t len,int advice);long sys32_fadvise64_64 (int fd,__u32 offset_low,__u32 offset_high,__u32 len_low,__u32 len_high,int advice)
arch/x86_64/ia32/sys_ia32.c +1 -1
@@ -1895,7 +1895,7 @@ sys32_timer_create(u32 clock, struct sigreturn err; } -extern long sys_fadvise64_64 (int fd,loff_t offset,loff_t len,int advice); +extern asmlinkage long sys_fadvise64_64 (int fd,loff_t offset,loff_t len,int advice);long sys32_fadvise64_64 (int fd,__u32 offset_low,__u32 offset_high,__u32 len_low,__u32 len_high,int advice)
include/linux/mm.h +2 -2
@@ -455,8 +455,8 @@ extern int install_file_pte(struct mm_stextern int handle_mm_fault (struct mm_struct *mm,struct vm_area_struct *vma,unsigned long address,int write_access);extern int make_pages_present (unsigned long addr,unsigned long end);extern int access_process_vm (struct task_struct *tsk,unsigned long addr,void *buf,int len,int write); -extern long sys_remap_file_pages (unsigned long start,unsigned long size,unsigned long prot,unsigned long pgoff,unsigned long nonblock); -extern long sys_fadvise64_64 (int fd,loff_t offset,loff_t len,int advice); +extern asmlinkage long sys_remap_file_pages (unsigned long start,unsigned long size,unsigned long prot,unsigned long pgoff,unsigned long nonblock); +extern asmlinkage long sys_fadvise64_64 (int fd,loff_t offset,loff_t len,int advice);void put_dirty_page (struct task_struct *tsk,struct page *page,unsigned long address,pgprot_t prot);
include/linux/shm.h +1 -1
@@ -90,7 +90,7 @@ struct shmid_kernel /* private to the ke#define SHM_LOCKED 02000/* segment will not be swapped */ #define SHM_HUGETLB 04000/* segment will use huge TLB pages */ -long sys_shmat (int shmid,char __user *shmaddr,int shmflg,unsigned long *addr); +asmlinkage long sys_shmat (int shmid,char __user *shmaddr,int shmflg,unsigned long *addr);asmlinkage long sys_shmget (key_t key,size_t size,int flag);asmlinkage long sys_shmdt (char __user *shmaddr);asmlinkage long sys_shmctl (int shmid,int cmd,struct shmid_ds __user *buf);
mm/fremap.c +1 -1
@@ -155,7 +155,7 @@ err_unlock:* protection is used. Arbitrary protections might be implemented in the * future. */ -long sys_remap_file_pages (unsigned long start,unsigned long size, +asmlinkage long sys_remap_file_pages (unsigned long start,unsigned long size,unsigned long __prot,unsigned long pgoff,unsigned long flags) {struct mm_struct *mm = current->mm;
Hello,
Quoted 2 lines
with
CONFIG_REGPARM=y, syscalls must be declared asmlinkage or else calling them will fail. [...]
here are a couple more cases where the prototypes and definitions don't match. I found them with a fixed gcc.
Regards,
Signature · 2 lines
Andreas Gruenbacher <[email protected]> SUSE Labs, SUSE LINUX AG
arch/i386/kernel/semaphore.c +8 -4
@@ -48,12 +48,14 @@* we cannot lose wakeup events. */ -void __up (struct semaphore *sem) +asmlinkage void +__up (struct semaphore *sem) {wake_up (&sem->wait); } -void __down (struct semaphore * sem) +asmlinkage void +__down (struct semaphore * sem) {struct task_struct *tsk = current;DECLARE_WAITQUEUE (wait, tsk);
@@ -90,7 +92,8 @@ void __down(struct semaphore * sem) tsk->state =TASK_RUNNING ; } -int __down_interruptible (struct semaphore * sem) +asmlinkage int +__down_interruptible (struct semaphore * sem) {int retval =0 ;struct task_struct *tsk = current;
@@ -153,7 +156,8 @@ int __down_interruptible(struct semaphor* single "cmpxchg" without failure cases, * but then it wouldn't work on a 386. */ -int __down_trylock (struct semaphore * sem) +asmlinkage int +__down_trylock (struct semaphore * sem) {int sleepers;unsigned long flags;
drivers/isdn/hysdn/hysdn_defs.h +0 -1
@@ -235,7 +235,6 @@ extern hysdn_card *card_root; /* pointer/*************************/ /* im/exported functions */ /*************************/ -extern int printk (const char *fmt,...);extern char *hysdn_getrev (const char *);/* hysdn_procconf.c */
kernel/exit.c +1 -1
@@ -748,7 +748,7 @@ static void exit_notify(struct task_stru } -NORET_TYPE void do_exit(long code) +asmlinkage NORET_TYPE void do_exit(long code) {struct task_struct *tsk = current;
kernel/power/swsusp.c +5 -5
@@ -72,7 +72,7 @@ extern long sys_sync(void);unsigned char software_suspend_enabled =0 ; -extern void do_magic (int resume); +asmlinkage extern void do_magic(int resume);#define NORESUME 1#define RESUME_SPECIFIED 2
@@ -584,7 +584,7 @@ static void suspend_power_down(void)* Magic happens here */ -void do_magic_resume_1 (void ) +asmlinkage void do_magic_resume_1(void) {barrier ();mb ();
@@ -597,7 +597,7 @@ void do_magic_resume_1(void)driver scheduled DMA, we have good chance for DMA to finish ;-). */ } -void do_magic_resume_2 (void ) +asmlinkage void do_magic_resume_2(void) {BUG_ON (nr_copy_pages_check != nr_copy_pages);BUG_ON (pagedir_order_check != pagedir_order);
@@ -641,7 +641,7 @@ void do_magic_resume_2(void)*/ -void do_magic_suspend_1 (void ) +asmlinkage void do_magic_suspend_1(void) {mb ();barrier ();
@@ -649,7 +649,7 @@ void do_magic_suspend_1(void)spin_lock_irq (&suspend_pagedir_lock); } -void do_magic_suspend_2 (void ) +asmlinkage void do_magic_suspend_2(void) {int is_problem;read_swapfiles ();